From: Ramsay Jones <ramsay@ramsay1•demon.co.uk>
To: Jonathan Nieder <jrnieder@gmail•com>
Cc: "Junio C Hamano" <gitster@pobox•com>,
"GIT Mailing-list" <git@vger•kernel.org>,
"Ævar Arnfjörð Bjarmason" <avarab@gmail•com>
Subject: Re: [RFC/PATCH] t3300-*.sh: Fix a TAP parse error
Date: Wed, 25 Jul 2012 19:36:22 +0100 [thread overview]
Message-ID: <50103CA6.4050901@ramsay1.demon.co.uk> (raw)
In-Reply-To: <20120724192103.GB5210@burratino>
Jonathan Nieder wrote:
> [...]
>> No, I don't think this would be a good direction to go in. This may
>> not be a good idea either, but if you wanted to add a check here, then
>> maybe something like this (totally untested):
>>
>> diff --git a/t/test-lib.sh b/t/test-lib.sh
>> index acda33d..53a2422 100644
>> --- a/t/test-lib.sh
>> +++ b/t/test-lib.sh
>> @@ -354,6 +354,9 @@ test_done () {
>> case "$test_failure" in
>> 0)
>> # Maybe print SKIP message
>> + if test -n "$skip_all" && test $test_count -gt 0; then
>> + error "Can't use skip_all after running some tests"
>> + fi
>> [ -z "$skip_all" ] || skip_all=" # SKIP $skip_all"
>>
>> if test $test_external_has_tap -eq 0; then
>
> I think preventing invalid TAP output like this would be a very good
> thing! As a start, this patchlet looks good to me, and then I guess
> we'll have to think more about what happens when a person wants to
> skip_all_remaining after a test has already been run.
>
> Care to format it as a "git am"-able patch, or should I?
Yes, I will happily create a proper (tested) patch and send it to the list.
However, given that we are now in the RC period, I probably won't get to it
immediately; I need to set aside *at least* one full evening to running the
testsuite on cygwin! ;-)
ATB,
Ramsay Jones
next prev parent reply other threads:[~2012-07-25 19:48 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-21 17:46 [RFC/PATCH] t3300-*.sh: Fix a TAP parse error Ramsay Jones
2012-07-21 18:20 ` Jonathan Nieder
2012-07-24 18:34 ` Ramsay Jones
2012-07-24 19:21 ` Jonathan Nieder
2012-07-25 18:36 ` Ramsay Jones [this message]
2012-07-24 19:57 ` Junio C Hamano
2012-07-25 19:07 ` Ramsay Jones
2012-07-25 20:51 ` Jonathan Nieder
2012-07-25 22:08 ` Junio C Hamano
2012-07-28 18:12 ` Ramsay Jones
2012-07-28 18:03 ` Ramsay Jones
2012-08-16 23:40 ` Junio C Hamano
2012-08-19 17:57 ` Ramsay Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50103CA6.4050901@ramsay1.demon.co.uk \
--to=ramsay@ramsay1$(echo .)demon.co.uk \
--cc=avarab@gmail$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=gitster@pobox$(echo .)com \
--cc=jrnieder@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox