public inbox for git@vger.kernel.org 
 help / color / mirror / Atom feed

From: Ramsay Jones <ramsay@ramsay1•demon.co.uk>
To: Brian Gernhardt <brian@gernhardtsoftware•com>
Cc: Git List <git@vger•kernel.org>, Thomas Rast <trast@student•ethz.ch>
Subject: Re: Test failures in t4034
Date: Sun, 19 Aug 2012 15:50:49 +0100	[thread overview]
Message-ID: <5030FD49.6060704@ramsay1.demon.co.uk> (raw)
In-Reply-To: <80B6C6EE-130C-48C3-BBBB-5FCD1E7EFDEF@gernhardtsoftware.com>

Brian Gernhardt wrote:
> I've been getting a couple of test failures and finally had the time to track them down.
> 
> t4034-diff-words fails tests "22 diff driver 'bibtex'" and "26 diff driver 'html'".  Bisecting shows that the file started giving me errors in commit 8d96e72 "t4034: bulk verify builtin word regex sanity", which appears to introduce those tests.  I don't see anything obviously wrong with the tests and I'm not familiar with the diff-words code, so I'm not sure what's wrong.
> 
> I am running on OS X 10.8, with Xcode 4.4.1 (llvm-gcc 4.2.1).

I had the same problem (or at least it *looks* like the same problem) on Linux
last year (May 2011), which turned out to be a bug in the regex routines in an
old version of glibc. 

I don't know OS X at all, so this may not be relevent; does OS X use glibc?
(I didn't think so, but ...)

I sent some patches to the list which may be helpful. I can't get to gmane to
look up a reference, but you need to search for:

    [RFC/PATCH] userdiff.c: Avoid old glibc regex bug causing t4034-*.sh test failures

sent on 3rd May 2011.

Also, in the same thread, a reply to Jonathan Nieder on 7th May contains a
test which checks whether your regex routines suffer this bug.

These patches were not applied since I didn't think this would be a common
problem. I simply set NO_REGEX=1 in my config.mak, since the compat/ regex
routines don't suffer from this problem.

HTH

ATB,
Ramsay Jones

next prev parent reply	other threads:[~2012-08-19 19:17 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-18  6:03 Test failures in t4034 Brian Gernhardt
2012-08-19  6:12 ` Junio C Hamano
     [not found]   ` <20449AC5-D068-46CF-B8C4-E0639FB92EF6@gernhardtsoftware.com>
2012-08-19 17:01     ` Junio C Hamano
2012-08-19 14:50 ` Ramsay Jones [this message]
2012-08-19 21:36   ` Johannes Sixt
2012-08-20  0:56   ` Junio C Hamano
2012-08-21 18:37     ` Ramsay Jones
2012-08-21 22:09       ` Junio C Hamano
2012-09-01 17:43         ` Ramsay Jones
2012-09-03  1:53           ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5030FD49.6060704@ramsay1.demon.co.uk \
    --to=ramsay@ramsay1$(echo .)demon.co.uk \
    --cc=brian@gernhardtsoftware$(echo .)com \
    --cc=git@vger$(echo .)kernel.org \
    --cc=trast@student$(echo .)ethz.ch \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox