From: David Gould <david@optimisefitness•com>
To: Junio C Hamano <gitster@pobox•com>
Cc: Jeff King <peff@peff•net>, Erik Faye-Lund <kusmabite@gmail•com>,
git@vger•kernel.org
Subject: Re: Probable bug in file run-command.c function clear_child_for_cleanup
Date: Tue, 11 Sep 2012 09:40:51 +0100 [thread overview]
Message-ID: <504EF913.2050202@optimisefitness.com> (raw)
In-Reply-To: <7v4nn5ocvv.fsf@alter.siamese.dyndns.org>
Hi guys,
Sorry for the delayed reply - what passes for my real life intruded
somewhat.
I'll get on to it today, but please be aware this will be my first-ever
patch for ANY project, so am likely to foul up the process.
I am reading the How To Submit Patches document even now....
Cheers,
David
On 10/09/12 21:12, Junio C Hamano wrote:
> Jeff King <peff@peff•net> writes:
>
>> On Mon, Sep 10, 2012 at 01:00:35PM -0700, Junio C Hamano wrote:
>>
>>>>> And to conclude my bikeshedding for the day: Shouldn't "last" ideally
>>>>> be called something like "prev" instead? It's the previously visited
>>>>> element, not the last element in the list.
>>>>
>>>> It is the "last" element visited (just as "last week" is not the end of
>>>> the world), but yes, it is ambiguous, and "prev" is not. Either is fine
>>>> by me.
>>>
>>> OK, so who's gonna do the honors?
>>
>> I was hoping to give David a chance to submit his first-ever patch to
>> git.
>
> OK. David, is it OK for us to expect a patch from you sometime not
> in distant future (it is an old bug we survived for a long time and
> nothing ultra-urgent)?
>
--
David Gould, Personal Trainer
Register of Kettlebell Professionals
INWA Nordic Walking Instructor
Optimise Fitness Ltd -- fit for life
01264 720709
www.optimisefitness.com
prev parent reply other threads:[~2012-09-11 8:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-09 14:44 Probable bug in file run-command.c function clear_child_for_cleanup David Gould
2012-09-10 13:44 ` Jeff King
2012-09-10 13:58 ` Erik Faye-Lund
2012-09-10 14:10 ` Jeff King
2012-09-10 20:00 ` Junio C Hamano
2012-09-10 20:01 ` Jeff King
2012-09-10 20:12 ` Junio C Hamano
2012-09-11 8:40 ` David Gould [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=504EF913.2050202@optimisefitness.com \
--to=david@optimisefitness$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=gitster@pobox$(echo .)com \
--cc=kusmabite@gmail$(echo .)com \
--cc=peff@peff$(echo .)net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox