Subject: Re: [PATCH 15/21] git p4 test: disable chmod test for cygwin

From: Johannes Sixt <[email-masked]>
Date: Fri, 28 Sep 2012 21:33:36 +0200

Am 28.09.2012 14:04, schrieb Pete Wyckoff:
> It does not notice chmod +x or -x; there is nothing
> for this test to do.
> 
> Signed-off-by: Pete Wyckoff <[email-masked]>
> ---
>  t/t9815-git-p4-submit-fail.sh | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/t/t9815-git-p4-submit-fail.sh b/t/t9815-git-p4-submit-fail.sh
> index d2b7b3d..2db1bf1 100755
> --- a/t/t9815-git-p4-submit-fail.sh
> +++ b/t/t9815-git-p4-submit-fail.sh
> @@ -400,7 +400,9 @@ test_expect_success 'cleanup rename after submit cancel' '
>  	)
>  '
>  
> -test_expect_success 'cleanup chmod after submit cancel' '
> +# chmods are not recognized in cygwin; git has nothing
> +# to commit
> +test_expect_success NOT_CYGWIN 'cleanup chmod after submit cancel' '
>  	test_when_finished cleanup_git &&
>  	git p4 clone --dest="$git" //depot &&
>  	(
> 

In the git part, you could use test_chmod to change the executable bit.
But if you cannot test it in the p4 part later on, it is probably not
worth it.

-- Hannes