From: Michael J Gruber <git@drmicha•warpmail.net>
To: Thiago Farina <tfransosi@gmail•com>
Cc: Andrew Wong <andrew.kw.w.lists@gmail•com>,
Andrew Wong <andrew.kw.w@gmail•com>,
Git Mailing List <git@vger•kernel.org>,
Scott Chacon <schacon@gmail•com>,
Junio C Hamano <gitster@pobox•com>
Subject: Re: build deps
Date: Mon, 15 Oct 2012 17:44:46 +0200 [thread overview]
Message-ID: <507C2F6E.9060100@drmicha.warpmail.net> (raw)
In-Reply-To: <CACnwZYfmz1BTo6okzFh8jXbw+0MAV0sEanYXNzAnV7L4p7nY_g@mail.gmail.com>
Thiago Farina venit, vidit, dixit 12.10.2012 06:08:
> On Thu, Oct 11, 2012 at 10:06 PM, Andrew Wong
> <andrew.kw.w.lists@gmail•com> wrote:
>> On 10/11/12 16:54, Thiago Farina wrote:
>>> Just setting CC to gcc works for me. But still, I'd like to be able to
>>> build with clang (may be as you noted is just something with the + in
>>> my PATH).
>> Oh, I just realized you were using "sudo". The PATH environment was
>> probably not inherited when you use sudo to run "make". So the
>> subsequent shells statred by "make' were not able to find "clang".
>
> Interesting, thank you for your observation.
>
> This worked for me now:
>
> $ git clone https://github.com/gitster/git
> $ cd git
> $ make configure
> $ ./configure
> $ make
> $ ./git version
> git version 1.8.0.rc2
>
> clang reported this:
> combine-diff.c:1006:19: warning: adding 'int' to a string does not
> append to the string [-Wstring-plus-int]
> prefix = COLONS + offset;
> ~~~~~~~^~~~~~~~
> combine-diff.c:1006:19: note: use array indexing to silence this
> warning
> prefix = COLONS + offset;
> ^
> & [ ]
> 1 warning generated.
Does
&COLONS[offset]
silence that?
> grep.c:451:16: warning: comparison of unsigned enum expression < 0 is
> always false [-Wtautological-compare]
> if (p->field < 0 || GREP_HEADER_FIELD_MAX <= p->field)
> ~~~~~~~~ ^ ~
> 1 warning generated.
>
Right, that enum type starts at 0. Junio, you last touched this area.
Can we just dump the first comparison or did you have something else in
mind?
Michael
next prev parent reply other threads:[~2012-10-15 15:45 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-08 0:39 build deps Thiago Farina
2012-10-08 16:09 ` Andrew Wong
2012-10-08 21:36 ` Thiago Farina
2012-10-08 21:37 ` Thiago Farina
2012-10-08 22:52 ` Andrew Wong
2012-10-11 20:54 ` Thiago Farina
2012-10-12 1:06 ` Andrew Wong
2012-10-12 4:08 ` Thiago Farina
2012-10-15 15:44 ` Michael J Gruber [this message]
2012-10-15 17:51 ` Thiago Farina
2012-10-15 20:53 ` Junio C Hamano
2012-10-16 1:39 ` David Aguilar
2012-10-16 7:37 ` Michael J Gruber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=507C2F6E.9060100@drmicha.warpmail.net \
--to=git@drmicha$(echo .)warpmail.net \
--cc=andrew.kw.w.lists@gmail$(echo .)com \
--cc=andrew.kw.w@gmail$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=gitster@pobox$(echo .)com \
--cc=schacon@gmail$(echo .)com \
--cc=tfransosi@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox