Subject: Re: [PATCH v4 09/14] remote-testgit: report success after an import

From: Stefano Lattarini <[email-masked]>
Date: Fri, 02 Nov 2012 14:58:43 +0100

On 11/02/2012 03:02 AM, Felipe Contreras wrote:
> Doesn't make a difference for the tests, but it does for the ones
> seeking reference.
> 
> Signed-off-by: Felipe Contreras <[email-masked]>
> ---
>  git-remote-testgit | 11 +++++++++++
>  1 file changed, 11 insertions(+)
> 
> diff --git a/git-remote-testgit b/git-remote-testgit
> index 6c348b0..4e8b356 100755
> --- a/git-remote-testgit
> +++ b/git-remote-testgit
> @@ -59,7 +59,18 @@ while read line; do
>              sed -e "s#refs/heads/#${prefix}/heads/#g"
>          ;;
>      export)
> +        declare -A before after
> +
If you convert this script to be a valid POSIX shell script (as I've
suggested in my reply to [PATCH v4 04/14]), you'll need to get rid of
this bashism (and those below) as well.

> +        eval $(git for-each-ref --format='before[%(refname)]=%(objectname)')
> +
>          git fast-import --{import,export}-marks="$testgitmarks" --quiet
> +
> +        eval $(git for-each-ref --format='after[%(refname)]=%(objectname)')
> +
> +        for ref in "${!after[@]}"; do
> +            test "${before[$ref]}" ==  "${after[$ref]}" && continue
> +            echo "ok $ref"
> +        done
>          echo
>          ;;
>      '')

Regards,
  Stefano