From: Lukasz Stelmach <stlman@poczta•fm>
To: Paul Mackerras <paulus@samba•org>
Cc: gitster@pobox•com, git@vger•kernel.org, mbranchaud@xiplink•com
Subject: Re: [PATCH] gitk: read and write a repository specific configuration file
Date: Sun, 09 Dec 2012 14:25:46 +0100 [thread overview]
Message-ID: <50C4915A.4040102@poczta.fm> (raw)
In-Reply-To: <20121209104426.GA20818@bloggs.ozlabs.ibm.com>
W dniu 09.12.2012 11:44, Paul Mackerras pisze:
> On Sun, Dec 09, 2012 at 01:18:08AM -0800, Junio C Hamano wrote:
>> Łukasz Stelmach <stlman@poczta•fm> writes:
>>
>>> Enable gitk read and write repository specific configuration
>>> file: ".git/k" if the file exists. To make gitk use the local
>>> file simply create one, e.g. with the touch(1) command.
>>>
>>> This is very useful if one uses different views for different
>>> repositories. Now there is no need to store all of them in
>>> ~/.gitk and make the views list needlessly long.
>>
>> I do not use gitk heavily myself, but I have a mixed feeling about
>> this patch.
>
> I agree, I think this would be surprising to people who are used to
> the way gitk works now.
>
> I could imagine having a checkbox in the Edit->Preferences dialog to
> say "Save configuration settings locally", and if you check that box,
> then it writes the configuration to .git/gitkconfig or whatever
> (having first saved that setting in the global ~/.gitk).
No this isn't a good idea. When you choose to save configuration locally
it means you've alredy changed it to match your local needs and making
it global does not seem reasonable.
> But I think it should be an opt-in thing.
It is opt-in now definitely. One needs to create the local config file,
even an empty one, for gitk to choose it upon doquit/savestuff. I agree
a checkbox may be more convenient but is it "opty" (as in opt-in) enough?
Then, the checkbox should be added to both "Preferences" and "Edit View"
dialogs, anything more?
>> In any case, the filename .git/k may be _cute_, but I do not think
>> we would want to see:
>>
>> $ ls .git
>> branches config HEAD index k objects
>> COMMIT_EDITMSG description hooks info logs refs
>>
>> It is too cryptic, unless the user _knows_ 'k' is for gitk. I'd
>> call it $GIT_DIR/gitkconfig or something, if I were supportive for
>> this feature (which I am not enthusiastic, yet).
>
> I agree with this too.
Sure, let's vote:
a) .git/gitk
b) .git/gitkconfig
c) .git/gitkrc
--
Było mi bardzo miło. Czwarta pospolita klęska, [...]
>Łukasz< Już nie katolicka lecz złodziejska. (c)PP
next prev parent reply other threads:[~2012-12-09 13:26 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-30 21:08 [PATCH] gitk: add a checkbox to control the visibility of tags Łukasz Stelmach
2012-12-02 2:16 ` Junio C Hamano
2012-12-02 21:25 ` Lukasz Stelmach
2012-12-02 21:29 ` [PATCH] gitk: read and write a repository specific configuration file Łukasz Stelmach
2012-12-03 21:15 ` Stefan Haller
2012-12-04 20:12 ` Lukasz Stelmach
2012-12-05 0:49 ` [PATCH v2] " Łukasz Stelmach
2012-12-05 15:20 ` Marc Branchaud
2012-12-08 11:27 ` [PATCH] " Łukasz Stelmach
2012-12-09 9:18 ` Junio C Hamano
2012-12-09 10:44 ` Paul Mackerras
2012-12-09 13:25 ` Lukasz Stelmach [this message]
2012-12-09 13:13 ` Lukasz Stelmach
2012-12-02 21:40 ` [PATCH] gitk: add a checkbox to control the visibility of tags Felipe Contreras
2013-01-02 7:17 ` Paul Mackerras
2013-01-02 7:24 ` Junio C Hamano
2013-01-02 8:03 ` Lukasz Stelmach
2013-01-02 17:08 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50C4915A.4040102@poczta.fm \
--to=stlman@poczta$(echo .)fm \
--cc=git@vger$(echo .)kernel.org \
--cc=gitster@pobox$(echo .)com \
--cc=mbranchaud@xiplink$(echo .)com \
--cc=paulus@samba$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox