Subject: Re: [PATCH 4/4] Declare that HP NonStop systems require strings.h

From: Johannes Sixt <[email-masked]>
Date: Sat, 15 Dec 2012 00:16:30 +0100

Am 14.12.2012 23:46, schrieb Joachim Schmitz:
> Johannes Sixt wrote:
>> Am 14.12.2012 20:57, schrieb David Michael:
>>> This platform previously included strings.h automatically.  However,
>>> the build system now requires an explicit option to do so.
>>>
>>> Signed-off-by: David Michael <[email-masked]>
>>> ---
>>>  Makefile | 1 +
>>>  1 file changed, 1 insertion(+)
>>>
>>> diff --git a/Makefile b/Makefile
>>> index fb78f7f..e84b0cb 100644
>>> --- a/Makefile
>>> +++ b/Makefile
>>> @@ -1357,6 +1357,7 @@ ifeq ($(uname_S),NONSTOP_KERNEL)
>>>      # Added manually, see above.
>>>      NEEDS_SSL_WITH_CURL = YesPlease
>>>      HAVE_LIBCHARSET_H = YesPlease
>>> +    HAVE_STRINGS_H = YesPlease
>>>      NEEDS_LIBICONV = YesPlease
>>>      NEEDS_LIBINTL_BEFORE_LIBICONV = YesPlease
>>>      NO_SYS_SELECT_H = UnfortunatelyYes
>>
>> If NONSTOP_KERNEL is the platform that defines __TANDEM, then this
>> should be squashed into the previous patch, shouldn't it?
> 
> Patch 4/4 does not work without 3/4, Not for HP-NonStop.

That is clear from the order of the patches in the series.

To put it in a different way: Do all supported platforms still work
after 3/4, but without 4/4?

-- Hannes