From: Sven Strickroth <sven.strickroth@tu-clausthal•de>
To: Jeff King <peff@peff•net>
Cc: msysgit@googlegroups•com, git@vger•kernel.org, gitster@pobox•com
Subject: Re: [PATCH] connect.c: Tell *PLink to always use ssh protocol
Date: Thu, 07 Feb 2013 10:40:57 +0100 [thread overview]
Message-ID: <511376A9.6030803@tu-clausthal.de> (raw)
In-Reply-To: <20130206232214.GN27507@sigill.intra.peff.net>
Am 07.02.2013 00:22 schrieb Jeff King:
> On Wed, Feb 06, 2013 at 10:58:49PM +0100, Sven Strickroth wrote:
>
>> Default values for *plink can be set using PuTTY. If a user makes
>> telnet the default in PuTTY this breaks ssh clones in git.
>>
>> Since git clones of the type user@host:path use ssh, tell *plink
>> to use ssh and override PuTTY defaults for the protocol to use.
>> ---
>> connect.c | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/connect.c b/connect.c
>> index 49e56ba..d337b6f 100644
>> --- a/connect.c
>> +++ b/connect.c
>> @@ -625,6 +625,8 @@ struct child_process *git_connect(int fd[2], const char *url_orig,
>> if (!ssh) ssh = "ssh";
>>
>> *arg++ = ssh;
>> + if (putty)
>> + *arg++ = "-ssh";
>> if (putty && !strcasestr(ssh, "tortoiseplink"))
>> *arg++ = "-batch";
>> if (port) {
Just for the completeness: This might have an unwanted side effect...
Using the -ssh parameter sets the protocol to ssh AND the port number to
22. This might break a setting where a user stores a PuTTY default for
ssh, but with a different port number (e.g. because a user always pushes
to a remote ssh repository which resides on a different port).
PuTTY settings for a named session still work, it only affects the
"Default Settings" session - so users can set up specific sessons in
PuTTY if he wants to change the default port.
--
Best regards,
Sven Strickroth
PGP key id F5A9D4C4 @ any key-server
--
--
*** Please reply-to-all at all times ***
*** (do not pretend to know who is subscribed and who is not) ***
*** Please avoid top-posting. ***
The msysGit Wiki is here: https://github.com/msysgit/msysgit/wiki - Github accounts are free.
You received this message because you are subscribed to the Google
Groups "msysGit" group.
To post to this group, send email to msysgit@googlegroups•com
To unsubscribe from this group, send email to
msysgit+unsubscribe@googlegroups•com
For more options, and view previous threads, visit this group at
http://groups.google.com/group/msysgit?hl=en_US?hl=en
---
You received this message because you are subscribed to the Google Groups "msysGit" group.
To unsubscribe from this group and stop receiving emails from it, send an email to msysgit+unsubscribe@googlegroups•com.
For more options, visit https://groups.google.com/groups/opt_out.
next prev parent reply other threads:[~2013-02-07 9:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-06 21:58 [PATCH] connect.c: Tell *PLink to always use ssh protocol Sven Strickroth
2013-02-06 23:22 ` Jeff King
2013-02-07 9:40 ` Sven Strickroth [this message]
2013-03-09 14:08 ` Sven Strickroth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=511376A9.6030803@tu-clausthal.de \
--to=sven.strickroth@tu-clausthal$(echo .)de \
--cc=git@vger$(echo .)kernel.org \
--cc=gitster@pobox$(echo .)com \
--cc=msysgit@googlegroups$(echo .)com \
--cc=peff@peff$(echo .)net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox