Subject: Re: [PATCH v2 02/12] pretty: share code between format_decoration and show_decorations

From: Jakub Narębski <[email-masked]>
Date: Fri, 05 Apr 2013 09:57:35 +0200

Junio C Hamano wrote:
> Nguyễn Thái Ngọc Duy  <[email-masked]> writes:

>> diff --git a/log-tree.h b/log-tree.h
>> index 9140f48..e6a2da5 100644
>> --- a/log-tree.h
>> +++ b/log-tree.h
>> @@ -13,6 +13,9 @@ int log_tree_diff_flush(struct rev_info *);
>>  int log_tree_commit(struct rev_info *, struct commit *);
>>  int log_tree_opt_parse(struct rev_info *, const char **, int);
>>  void show_log(struct rev_info *opt);
>> +void format_decoration(struct strbuf *sb,
>> +		       const struct commit *commit,
>> +		       int use_color);
> 
> I think you can fit these on a single line, especially if you drop
> the unused variable names (they help when there are more than one
> parameter of the same type to document the order of the arguments,
> but that does not apply here).  That would help people who run
> "grep" on the header files without using CTAGS/ETAGS.

Well, I think "int use_color" should be left with variable name,
don't you think?

-- 
Jakub Narębski