public inbox for git@vger.kernel.org 
 help / color / mirror / Atom feed
From: Marc Branchaud <marcnarc@xiplink•com>
To: Ramkumar Ramachandra <artagnon@gmail•com>
Cc: Junio C Hamano <gitster@pobox•com>,
	Git List <git@vger•kernel.org>, Duy Nguyen <pclouds@gmail•com>,
	Jeff King <peff@peff•net>
Subject: Re: [RFC/PATCH] clone: introduce clone.submoduleGitDir to relocate $GITDIR
Date: Tue, 16 Apr 2013 11:46:07 -0400	[thread overview]
Message-ID: <516D723F.9070204@xiplink.com> (raw)
In-Reply-To: <CALkWK0kEQ+mCxkaqUusyaEpx350qNrJ8UPoeo7+hEVGEUbtaxQ@mail.gmail.com>

On 13-04-16 04:17 AM, Ramkumar Ramachandra wrote:
> Marc Branchaud wrote:
>> If "git add" is all about specifying what lives under paths in the worktree,
>> what's wrong with letting "git add" go beyond specifying just files?
>>
>> Syntax aside for the moment, I think a command like
>>         git add git-repo-reference foo
>> is perfectly natural:  It specifies what is inside worktree path foo.
> 
> I never said "just files".  Files, directories, symlinks and
> submodules are all "things in the worktree", and all fine.  Remote
> URLs, on the other hand, have nothing to do with the worktree.

But they have everything to do with submodules.  You need a URL to identify a
submodule.  If you want a submodule in your worktree, at some point you have
to specify the submodule's URL.

I really feel like I'm missing something here.  You seem to be saying that
it's wrong to let "git add" interpret a URL as a submodule.  Instead you seem
to want to have some other mechanism create the files, directories and
symlinks that make up a submodule, so that "git add" can then operate with
the purity you desire.  That's what I don't understand.

As a submodule user, I want to "git add" a submodule.  I don't see why it's
necessary to have more than one command to do that.  But if you're saying
that it's fine for "git add" to work this way, then I don't see the point of
the proposed change to "git clone".

		M.

  reply	other threads:[~2013-04-16 15:46 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-13 19:23 [RFC/PATCH] clone: introduce clone.submoduleGitDir to relocate $GITDIR Ramkumar Ramachandra
2013-04-15  1:28 ` Junio C Hamano
2013-04-15  2:48   ` Junio C Hamano
2013-04-15  8:08     ` Ramkumar Ramachandra
2013-04-15 10:14       ` Junio C Hamano
2013-04-15 11:35         ` Ramkumar Ramachandra
2013-04-15  7:59   ` Ramkumar Ramachandra
2013-04-15  8:19   ` Ramkumar Ramachandra
2013-04-15  9:25     ` Duy Nguyen
2013-04-15  9:47       ` Ramkumar Ramachandra
2013-04-15  9:45     ` Junio C Hamano
2013-04-15 11:48       ` Ramkumar Ramachandra
2013-04-15 15:50     ` Marc Branchaud
2013-04-15 17:50       ` Junio C Hamano
2013-04-15 18:00         ` Ramkumar Ramachandra
2013-04-15 18:43           ` Jeff King
2013-04-15 20:52             ` Junio C Hamano
2013-04-16  8:13             ` Ramkumar Ramachandra
2013-04-16 15:39               ` Marc Branchaud
2013-04-15 18:50           ` Marc Branchaud
2013-04-16  8:17             ` Ramkumar Ramachandra
2013-04-16 15:46               ` Marc Branchaud [this message]
2013-04-15 18:43         ` Marc Branchaud
2013-04-15 18:50           ` Junio C Hamano
2013-04-15 20:32             ` Marc Branchaud
2013-04-15 20:56               ` Junio C Hamano
2013-04-16  8:21             ` Ramkumar Ramachandra
2013-04-16 15:46               ` Marc Branchaud
2013-04-15 17:50       ` Ramkumar Ramachandra
2013-04-16  2:58 ` Jonathan Nieder
2013-04-16  8:36   ` Ramkumar Ramachandra
2013-04-16 17:28     ` Junio C Hamano
2013-04-17 15:48     ` Jonathan Nieder
2013-04-17 10:22 ` Duy Nguyen
2013-04-17 10:53   ` Ramkumar Ramachandra
2013-04-17 10:59     ` Duy Nguyen
2013-04-17 11:13       ` Ramkumar Ramachandra
2013-04-17 11:36         ` Duy Nguyen
2013-04-17 15:02           ` Ramkumar Ramachandra
2013-04-17 23:01             ` Duy Nguyen
2013-04-17 17:18           ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=516D723F.9070204@xiplink.com \
    --to=marcnarc@xiplink$(echo .)com \
    --cc=artagnon@gmail$(echo .)com \
    --cc=git@vger$(echo .)kernel.org \
    --cc=gitster@pobox$(echo .)com \
    --cc=pclouds@gmail$(echo .)com \
    --cc=peff@peff$(echo .)net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox