From: Michael J Gruber <git@drmicha•warpmail.net>
To: Joel Jacobson <joel@trustly•com>
Cc: Junio C Hamano <gitster@pobox•com>, git@vger•kernel.org
Subject: Re: [PATCH] Add .gitconfig variable commit.gpg-sign
Date: Tue, 23 Apr 2013 13:37:52 +0200 [thread overview]
Message-ID: <51767290.2010208@drmicha.warpmail.net> (raw)
In-Reply-To: <CAASwCXcfCNqiMXD5JasTRKWZgCNsxnUY7k9E=f86xsTZjk37CA@mail.gmail.com>
Joel Jacobson venit, vidit, dixit 23.04.2013 02:00:
> On Tue, Apr 23, 2013 at 12:43 AM, Junio C Hamano <gitster@pobox•com> wrote:
>> No docs? No tests?
>
> Maybe simply adding this text to git-commit.txt,
>
> The default can be changed by the 'commit.gpg-sign' configuration
> variable (see linkgit:git-config[1]).
>
> after,
>
> -S[<keyid>]::
> --gpg-sign[=<keyid>]::
> GPG-sign commit.
>
> would be sufficient?
>
> Not sure what the proper way to test this,
> could you please suggest any other unit test I could look at for inspiration?
>
>> As to the design, any regular configuration variable settings must
>> be overridable from the command line for a single invocation. Please
>> design an escape hatch in, for somebody who has this configuration
>> variable set, but does not want to sign this commit he is about to
>> make.
>
> Something like --no-gpg-sign?
>
>> Also do we generally use dash in the configuration variable names?
>> I thought the norm was section.CamelCase.
>
> Since the command line long option is "gpg-sign", I thought it was best
> to use exactly the same term in the configuration variable name to
> avoid confusion. Is there any problem with dashes in variable names?
>
Not really a problem, but as Junio writes, we don't use dashes in the
config.
As for the command line override:
Don't we have "git -c commit.gpgsign=false" and such these days, so that
we don't have to inflate options any more?
Michael
next prev parent reply other threads:[~2013-04-23 11:37 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CAASwCXf3YHmdQ_eSkShyzn5VniO=ufm3VTqV1JVOUN610bzE_A@mail.gmail.com>
2013-04-22 23:43 ` [PATCH] Add .gitconfig variable commit.gpg-sign Junio C Hamano
2013-04-23 0:00 ` Joel Jacobson
2013-04-23 11:37 ` Michael J Gruber [this message]
2013-04-23 17:53 ` Junio C Hamano
2013-04-23 17:58 ` Joel Jacobson
2013-04-23 19:25 ` Junio C Hamano
2013-04-23 19:56 ` Joel Jacobson
2013-04-24 8:53 ` Sebastian Götte
2013-04-24 9:51 ` Michael J Gruber
2013-04-24 17:30 ` [PATCH 1/1] templates: pre-push hook: check for missing GPG signatures (was: Re: [PATCH] Add .gitconfig variable commit.gpg-sign) Sebastian Götte
2013-04-24 19:54 ` [PATCH 1/1] templates: pre-push hook: check for missing GPG signatures Junio C Hamano
2013-04-25 12:19 ` [PATCH v2 0/1] " Sebastian Götte
2013-04-25 16:50 ` Junio C Hamano
[not found] ` <cover.1366890748.git.jaseg@physik-pool.tu-berlin.de>
2013-04-25 12:19 ` [PATCH v2 1/1] " Sebastian Götte
2013-04-23 14:01 ` [PATCH] Add .gitconfig variable commit.gpg-sign Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51767290.2010208@drmicha.warpmail.net \
--to=git@drmicha$(echo .)warpmail.net \
--cc=git@vger$(echo .)kernel.org \
--cc=gitster@pobox$(echo .)com \
--cc=joel@trustly$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox