Subject: Re: [PATCH v3 22/28] git-remote-mediawiki: Modify strings for a better coding-style

From: Célestin Matte <[email-masked]>
Date: Mon, 10 Jun 2013 13:00:06 +0200

Le 10/06/2013 10:37, Matthieu Moy a écrit :
> Célestin Matte <[email-masked]> writes:
> 
>> @@ -1285,8 +1285,7 @@ sub get_mw_namespace_id {
>>  		# Look at configuration file, if the record for that namespace is
>>  		# already cached. Namespaces are stored in form:
>>  		# "Name_of_namespace:Id_namespace", ex.: "File:6".
>> -		my @temp = split(/\n/, run_git("config --get-all remote."
>> -						. $remotename .".namespaceCache"));
>> +		my @temp = split(/\n/, run_git("config --get-all remote.${remotename}.namespaceCache"));
> 
> I tend to prefer the former, as it avoids long lines (> 80 columns)

The 80-columns rule is already broken in *many* places in this file.
I know this is not a valid reason to do it more often, but in my opinion
the second version is easier to read (it's easy to miss the dots in the
first version), so we would gain from the change.

-- 
Célestin Matte