Subject: Re: [PATCH] Do not call built-in aliases from scripts

From: Johannes Sixt <[email-masked]>
Date: Thu, 27 Jun 2013 21:57:34 +0200

Am 27.06.2013 14:47, schrieb Sebastian Schuberth:
> diff --git a/git-archimport.perl b/git-archimport.perl
> index 9cb123a..ed2c741 100755
> --- a/git-archimport.perl
> +++ b/git-archimport.perl
...
> @@ -477,8 +477,8 @@ sub process_patchset_fast {
>          unlink @$del;
>          while (@$del) {
>              my @slice = splice(@$del, 0, 100);
> -            system('git-update-index','--remove','--',@slice) == 0 or
> -                            die "Error in git-update-index --remove: $! $?\n";
> +            system('git update-index','--remove','--',@slice) == 0 or
> +                            die "Error in git update-index --remove: $! $?\n";

Shouldn't this become 'git','update-index'?

>          }
>      }
> 
> @@ -496,25 +496,25 @@ sub process_patchset_fast {
>              }
>              # print "moving $from $to";
>              rename($from, $to) or die "Error renaming '$from' '$to': $!\n";
> -            system('git-update-index','--remove','--',$from) == 0 or
> -                            die "Error in git-update-index --remove: $! $?\n";
> -            system('git-update-index','--add','--',$to) == 0 or
> -                            die "Error in git-update-index --add: $! $?\n";
> +            system('git update-index','--remove','--',$from) == 0 or
> +                            die "Error in git update-index --remove: $! $?\n";
> +            system('git update-index','--add','--',$to) == 0 or
> +                            die "Error in git update-index --add: $! $?\n";

Twice here, too.

>          }
>      }
> 
>      if (my $add = $ps->{new_files}) {
>          while (@$add) {
>              my @slice = splice(@$add, 0, 100);
> -            system('git-update-index','--add','--',@slice) == 0 or
> -                            die "Error in git-update-index --add: $! $?\n";
> +            system('git update-index','--add','--',@slice) == 0 or
> +                            die "Error in git update-index --add: $! $?\n";

Again.

>          }
>      }
> 
>      if (my $mod = $ps->{modified_files}) {
>          while (@$mod) {
>              my @slice = splice(@$mod, 0, 100);
> -            system('git-update-index','--',@slice) == 0 or
> +            system('git update-index','--',@slice) == 0 or

Ditto.

-- Hannes

-- 
-- 
*** Please reply-to-all at all times ***
*** (do not pretend to know who is subscribed and who is not) ***
*** Please avoid top-posting. ***
The msysGit Wiki is here: https://github.com/msysgit/msysgit/wiki - Github accounts are free.

You received this message because you are subscribed to the Google
Groups "msysGit" group.
To post to this group, send email to [email-masked]
To unsubscribe from this group, send email to
[email-masked]
For more options, and view previous threads, visit this group at
http://groups.google.com/group/msysgit?hl=en_US?hl=en

--- 
You received this message because you are subscribed to the Google Groups "msysGit" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email-masked].
For more options, visit https://groups.google.com/groups/opt_out.