Subject: Re: [PATCH v7 2/7] wrap-for-bin: Make bin-wrappers chainable

From: Michael Haggerty <[email-masked]>
Date: Wed, 03 Jul 2013 12:30:49 +0200

On 07/03/2013 12:39 AM, [email-masked] wrote:
> From: Benoit Person <[email-masked]>
> 
> For now, bin-wrappers (based on wrap-for-bin.sh) redefine some
> environnement variables (like $GITPERLLIB). If we want to chain to
> those scripts and define one of those variables before, our changes
> will be overwritten.
> 
> This patch simply makes the bin-wrappers prepend their modifications
> rather than redefine the vars.

Your commit message makes it sound like GITPERLLIB is only one example
of a general class of environment variables fixed by the patch, but in
fact the patch address *only* GITPERLLIB.  Please make the commit
message better match the patch.

And maybe you could mention for posterity whether you have seen other
variables that will need fixing vs. you did an audit and think that
GITPERLLIB is the only problematic one vs. you haven't looked for other
similar problems at all.  This could save some time for the next person
with a similar itch and/or maybe inspire somebody to do an audit.

Thanks,
Michael

> Signed-off-by: Benoit Person <[email-masked]>
> Signed-off-by: Matthieu Moy <[email-masked]>
> ---
>  wrap-for-bin.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/wrap-for-bin.sh b/wrap-for-bin.sh
> index 53a8dd0..dbebe49 100644
> --- a/wrap-for-bin.sh
> +++ b/wrap-for-bin.sh
> @@ -14,7 +14,7 @@ else
>  	GIT_TEMPLATE_DIR='@@BUILD_DIR@@/templates/blt'
>  	export GIT_TEMPLATE_DIR
>  fi
> -GITPERLLIB='@@BUILD_DIR@@/perl/blib/lib'
> +GITPERLLIB='@@BUILD_DIR@@/perl/blib/lib:'"$GITPERLLIB"
>  GIT_TEXTDOMAINDIR='@@BUILD_DIR@@/po/build/locale'
>  PATH='@@BUILD_DIR@@/bin-wrappers:'"$PATH"
>  export GIT_EXEC_PATH GITPERLLIB PATH GIT_TEXTDOMAINDIR
> 

-- 
Michael Haggerty
[email-masked]
http://softwareswirl.blogspot.com/