From: Ramsay Jones <ramsay@ramsay1•demon.co.uk>
To: Mark Levedahl <mlevedahl@gmail•com>
Cc: Junio C Hamano <gitster@pobox•com>, git@vger•kernel.org
Subject: Re: [PATCH] Cygwin has trustable filemode
Date: Sat, 20 Jul 2013 21:12:11 +0100 [thread overview]
Message-ID: <51EAEF1B.6090300@ramsay1.demon.co.uk> (raw)
In-Reply-To: <51E982D0.5040505@gmail.com>
Mark Levedahl wrote:
> On 07/19/2013 12:40 PM, Junio C Hamano wrote:
>> Thanks, will replace.
>>
>> What do we want to do with the compat/regex build-time switch?
>>
>> IIRC, this was only needed for 1.7 and not 1.5, and I also would
>> expect (without anything to back-up, so this is more a faith than
>> expectation) over time the "new library" would have a working regex
>> library.
>>
>
> The situation is that Cygwin uses newlib rather than glibc, and does so
> for licesnsing reasons (redhat sells licenses to developers allowing
> closed source applications built using Cygwin). So, there must be a
> compelling need to fix the library - git has a simple work around, so
> isn't the case. Also, Cygwin has a perl regex library for those
> demanding more complete / correct regex solution. So, I make no
> prediction on when the newlib regex functions are fixed.
>
> Related: Should we have separate settings for 1.5 and 1.7 for several
> variables?
We already do.
> Conflicts I see not reflected in config.mak.uname on pu:
> trustable filemode (1.7 has, 1.5 does not)
I see no need for any difference here. puzzled.
> MMAP/Pread (1.7 pread is thread safe, 1.5 I dont think was, MMAP
> utility is convolved in this)
pread() is now thread-safe? great! (It must have been a fairly recent
change; last time I looked it was still not thread-safe on 1.7.)
> regex - 1.7 is broken, per Ramsay 1.5 works
I don't see any reason not to use the compat/regex routines on both
cygwin 1.5 and 1.7. However, I wouldn't object to restricting the use
of the compat routines to cygwin 1.7 either!
> If you think its worth it, I'll create a patch series with the above and
> justifications for the different settings that I know.
As far as I can see, only the pread() and maybe MMAP and regex setting
need to change from the current setup.
ATB,
Ramsay Jones
next prev parent reply other threads:[~2013-07-20 20:19 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-14 16:13 [PATCH] Cygwin has trustable filemode Mark Levedahl
2013-07-16 21:20 ` Ramsay Jones
2013-07-16 23:22 ` Mark Levedahl
2013-07-19 14:53 ` Mark Levedahl
2013-07-19 16:40 ` Junio C Hamano
2013-07-19 18:17 ` Mark Levedahl
2013-07-19 19:16 ` Junio C Hamano
2013-07-19 23:07 ` Mark Levedahl
2013-07-19 23:08 ` [PATCH 1/4] Cygwin 1.7 " Mark Levedahl
2013-07-19 23:08 ` [PATCH 2/4] Cygwin 1.7 needs compat/regex Mark Levedahl
2013-07-19 23:08 ` [PATCH 3/4] Cygwin 1.7 has thread-safe pread Mark Levedahl
2013-07-19 23:08 ` [PATCH 4/4] Cygwin 1.7 supports mmap Mark Levedahl
2013-07-19 23:09 ` [PATCH] Cygwin has trustable filemode Jonathan Nieder
2013-07-20 20:12 ` Ramsay Jones [this message]
2013-07-20 19:52 ` Ramsay Jones
2013-07-21 21:56 ` Junio C Hamano
2013-07-22 3:30 ` Mark Levedahl
2013-07-22 5:02 ` Junio C Hamano
2013-07-22 22:22 ` Mark Levedahl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51EAEF1B.6090300@ramsay1.demon.co.uk \
--to=ramsay@ramsay1$(echo .)demon.co.uk \
--cc=git@vger$(echo .)kernel.org \
--cc=gitster@pobox$(echo .)com \
--cc=mlevedahl@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox