From: Johannes Sixt <j6t@kdbg•org>
To: Ralf Baechle <ralf@linux-mips•org>
Cc: Madhavan Srinivasan <maddy@linux•vnet.ibm.com>,
Grant Likely <grant.likely@linaro•org>,
Rob Herring <rob.herring@calxeda•com>,
devicetree@vger•kernel.org, git@vger•kernel.org,
steven.hill@imgtec•com, mmarek@suse•cz, swarren@nvidia•com,
linux-mips@linux-mips•org, linux-kbuild@vger•kernel.org,
james.hogan@imgtec•com
Subject: Re: git issue / [PATCH] MIPS: fix invalid symbolic link file
Date: Thu, 19 Sep 2013 21:49:50 +0200 [thread overview]
Message-ID: <523B555E.2070508@kdbg.org> (raw)
In-Reply-To: <20130919133920.GA22468@linux-mips.org>
Am 19.09.2013 15:39, schrieb Ralf Baechle:
> The original patch that introduced the symlink with the \n is kernel
> commit 3b29aa5ba204c62b3ec8f9f5b1ebd6e5d74f75d3 and is archived in
> patchwork at http://patchwork.linux-mips.org/patch/5745/ The patch
> file contains a \n at the end - but one would expect that from a
> patch file that has been transfered via email, so I'm not sure how this
> is supposed to work with emailed patches?!?
The mbox file I downloaded from this link looks like this:
arch/mips/boot/dts/include/dt-bindings | 1 +
1 file changed, 1 insertion(+)
create mode 120000 arch/mips/boot/dts/include/dt-bindings
\ No newline at end of file
diff --git a/.../include/dt-bindings b/.../include/dt-bindings
new file mode 120000
index 0000000..08c00e4
--- /dev/null
+++ b/arch/mips/boot/dts/include/dt-bindings
@@ -0,0 +1 @@
+../../../../../include/dt-bindings
but it should look like this:
arch/mips/boot/dts/include/dt-bindings | 1 +
1 file changed, 1 insertion(+)
create mode 120000 arch/mips/boot/dts/include/dt-bindings
diff --git a/.../include/dt-bindings b/.../include/dt-bindings
new file mode 120000
index 0000000..08c00e4
--- /dev/null
+++ b/arch/mips/boot/dts/include/dt-bindings
@@ -0,0 +1 @@
+../../../../../include/dt-bindings
\ No newline at end of file
Whoever or whatever moved the '\ No newline at end of file' line above
the patch text is to blame.
-- Hannes
next prev parent reply other threads:[~2013-09-19 19:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1379596148-32520-1-git-send-email-maddy@linux.vnet.ibm.com>
2013-09-19 13:39 ` git issue / [PATCH] MIPS: fix invalid symbolic link file Ralf Baechle
[not found] ` <20130919133920.GA22468-6z/3iImG2C8G8FEW9MqTrA@public.gmane.org>
2013-09-19 16:37 ` Junio C Hamano
2013-09-19 19:49 ` Johannes Sixt [this message]
2013-09-19 20:36 ` Stephen Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=523B555E.2070508@kdbg.org \
--to=j6t@kdbg$(echo .)org \
--cc=devicetree@vger$(echo .)kernel.org \
--cc=git@vger$(echo .)kernel.org \
--cc=grant.likely@linaro$(echo .)org \
--cc=james.hogan@imgtec$(echo .)com \
--cc=linux-kbuild@vger$(echo .)kernel.org \
--cc=linux-mips@linux-mips$(echo .)org \
--cc=maddy@linux$(echo .)vnet.ibm.com \
--cc=mmarek@suse$(echo .)cz \
--cc=ralf@linux-mips$(echo .)org \
--cc=rob.herring@calxeda$(echo .)com \
--cc=steven.hill@imgtec$(echo .)com \
--cc=swarren@nvidia$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox