From: Heiko Voigt <hvoigt@hvoigt•net>
To: Karsten Blees <karsten.blees@gmail•com>,
Git List <git@vger•kernel.org>,
Junio C Hamano <gitster@pobox•com>
Cc: Thomas Rast <tr@thomasrast•ch>, Jens Lehmann <Jens.Lehmann@web•de>
Subject: Re: [PATCH v4 01/14] submodule: don't access the .gitmodules cache entry after removing it
Date: Thu, 07 Nov 2013 23:27:06 +0100 [thread overview]
Message-ID: <527C13BA.1030205@hvoigt.net> (raw)
In-Reply-To: <527BA4C7.4020700@gmail.com>
Hi,
it looks like there is a "From: Jens ..." line missing on top of this patch.
Am 07.11.2013 15:33, schrieb Karsten Blees:
> Commit 5fee995244e introduced the stage_updated_gitmodules() function to
> add submodule configuration updates to the index. It assumed that even
> after calling remove_cache_entry_at() the same cache entry would still be
> valid. This was true in the old days, as cache entries could never be
> freed, but that is not so sure in the present as there is ongoing work to
> free removed cache entries, which makes this code segfault.
>
> Fix that by calling add_file_to_cache() instead of open coding it. Also
> remove the "could not find .gitmodules in index" warning, as that won't
> happen in regular use cases (and by then just silently adding it to the
> index we do the right thing).
>
> Thanks-to: Karsten Blees <karsten.blees@gmail•com>
> Signed-off-by: Jens Lehmann <Jens.Lehmann@web•de>
> Signed-off-by: Junio C Hamano <gitster@pobox•com>
Cheers Heiko
next prev parent reply other threads:[~2013-11-07 22:27 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-07 14:32 [PATCH v4 00/14] New hash table implementation Karsten Blees
2013-11-07 14:33 ` [PATCH v4 01/14] submodule: don't access the .gitmodules cache entry after removing it Karsten Blees
2013-11-07 22:27 ` Heiko Voigt [this message]
2013-11-07 14:34 ` [PATCH v4 02/14] add a hashtable implementation that supports O(1) removal Karsten Blees
2013-11-07 21:40 ` Junio C Hamano
2013-11-08 10:27 ` Karsten Blees
2013-11-08 16:45 ` Philip Oakley
2013-11-08 17:08 ` Junio C Hamano
2013-11-13 16:37 ` Karsten Blees
2013-11-07 14:35 ` [PATCH v4 03/14] buitin/describe.c: use new hash map implementation Karsten Blees
2013-11-07 14:36 ` [PATCH v4 04/14] diffcore-rename.c: move code around to prepare for the next patch Karsten Blees
2013-11-07 14:36 ` [PATCH v4 05/14] diffcore-rename.c: simplify finding exact renames Karsten Blees
2013-11-07 14:37 ` [PATCH v4 06/14] diffcore-rename.c: use new hash map implementation Karsten Blees
2013-11-07 14:38 ` [PATCH v4 07/14] name-hash.c: use new hash map implementation for directories Karsten Blees
2013-11-07 14:38 ` [PATCH v4 08/14] name-hash.c: remove unreferenced directory entries Karsten Blees
2013-11-07 14:39 ` [PATCH v4 09/14] name-hash.c: use new hash map implementation for cache entries Karsten Blees
2013-11-07 14:39 ` [PATCH v4 10/14] name-hash.c: remove cache entries instead of marking them CE_UNHASHED Karsten Blees
2013-11-07 14:40 ` [PATCH v4 11/14] remove old hash.[ch] implementation Karsten Blees
2013-11-07 14:43 ` [PATCH v4 12/14] fix 'git update-index --verbose --again' output Karsten Blees
2013-11-07 22:12 ` Junio C Hamano
2013-11-08 10:27 ` Karsten Blees
2013-11-07 14:44 ` [PATCH v4 13/14] builtin/update-index.c: cleanup update_one Karsten Blees
2013-11-07 21:40 ` Junio C Hamano
2013-11-08 10:27 ` Karsten Blees
2013-11-07 14:45 ` [PATCH v4 14/14] read-cache.c: fix memory leaks caused by removed cache entries Karsten Blees
2013-11-07 21:40 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=527C13BA.1030205@hvoigt.net \
--to=hvoigt@hvoigt$(echo .)net \
--cc=Jens.Lehmann@web$(echo .)de \
--cc=git@vger$(echo .)kernel.org \
--cc=gitster@pobox$(echo .)com \
--cc=karsten.blees@gmail$(echo .)com \
--cc=tr@thomasrast$(echo .)ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox