Subject: Re: [PATCH 6/7] test-hg.sh: help user correlate verbose output with email test

From: Richard Hansen <[email-masked]>
Date: Mon, 11 Nov 2013 14:19:46 -0500

On 2013-11-11 06:42, Felipe Contreras wrote:
> Richard Hansen wrote:
>> It's hard to tell which author conversion test failed when the email
>> addresses look similar.
>>
>> Signed-off-by: Richard Hansen <[email-masked]>
>> ---
>>  contrib/remote-helpers/test-hg.sh | 20 ++++++++++----------
>>  1 file changed, 10 insertions(+), 10 deletions(-)
>>
>> diff --git a/contrib/remote-helpers/test-hg.sh b/contrib/remote-helpers/test-hg.sh
>> index 84c67ff..5eda265 100755
>> --- a/contrib/remote-helpers/test-hg.sh
>> +++ b/contrib/remote-helpers/test-hg.sh
>> @@ -209,16 +209,16 @@ test_expect_success 'authors' '
>>  
>>  	>../expected &&
>>  	author_test alpha "" "H G Wells <[email-masked]>" &&
>> -	author_test beta "test" "test <unknown>" &&
>> -	author_test beta "test <[email-masked]> (comment)" "test <[email-masked]>" &&

Notice the two betas here in the original code.

>> -	author_test gamma "<[email-masked]>" "Unknown <[email-masked]>" &&
>> -	author_test delta "name<[email-masked]>" "name <[email-masked]>" &&
>> -	author_test epsilon "name <[email-masked]" "name <[email-masked]>" &&
>> -	author_test zeta " test " "test <unknown>" &&
>> -	author_test eta "test < [email-masked] >" "test <[email-masked]>" &&
>> -	author_test theta "test >[email-masked]>" "test <[email-masked]>" &&
>> -	author_test iota "test < test <at> example <dot> com>" "test <unknown>" &&
>> -	author_test kappa "[email-masked]" "Unknown <[email-masked]>"
>> +	author_test beta "beta" "beta <unknown>" &&
>> +	author_test beta "beta <[email-masked]> (comment)" "beta <[email-masked]>" &&
> 
> Two betas?

See above.  I can change them to beta1 and beta2, or if you'd prefer I
can change them to beta and gamma and increment the subsequent entries.

Thanks,
Richard

> 
>> +	author_test gamma "<[email-masked]>" "Unknown <[email-masked]>" &&
>> +	author_test delta "delta<[email-masked]>" "delta <[email-masked]>" &&
>> +	author_test epsilon "epsilon <[email-masked]" "epsilon <[email-masked]>" &&
>> +	author_test zeta " zeta " "zeta <unknown>" &&
>> +	author_test eta "eta < [email-masked] >" "eta <[email-masked]>" &&
>> +	author_test theta "theta >[email-masked]>" "theta <[email-masked]>" &&
>> +	author_test iota "iota < test <at> example <dot> com>" "iota <unknown>" &&
>> +	author_test kappa "[email-masked]" "Unknown <[email-masked]>"
>>  	) &&
>>  
>>  	git clone "hg::hgrepo" gitrepo &&
>