Subject: Re: [PATCH] path_treatment: also ignore $GIT_DIR if it's not .git

From: Karsten Blees <[email-masked]>
Date: Tue, 03 Dec 2013 20:00:03 +0100

Am 03.12.2013 19:32, schrieb Junio C Hamano:
> Karsten Blees <[email-masked]> writes:
> 
>> So I figure that GIT_DIR is not meant to _rename_ the ".git" dir,
>> but to point somewhere _outside_ the worktree (or somewhere within
>> the .git dir).
> 
> Correct.
> 
>> If we don't want to support this, though, I think it would be more
>> approrpiate to issue a warning if GIT_DIR points to a worktree
>> location.
> 
> But how do tell what is and isn't a "worktree location"?  Having the
> path in the index would be one, but you may find it out only after
> issuing "git checkout $antient_commit".
> 

In setup_work_tree(), the result of remove_leading_path(git_dir, work_tree) must be absolute or start with ".." or ".git", otherwise warn?