From: Michael J Gruber <git@drmicha•warpmail.net>
To: Jonathan Nieder <jrnieder@gmail•com>, John Keeping <john@keeping•me.uk>
Cc: git@vger•kernel.org, Junio C Hamano <gitster@pobox•com>
Subject: Re: [PATCH jk/remove-deprecated] stop installing git-tar-tree link
Date: Wed, 04 Dec 2013 11:23:31 +0100 [thread overview]
Message-ID: <529F02A3.2030704@drmicha.warpmail.net> (raw)
In-Reply-To: <20131202233710.GB29959@google.com>
Jonathan Nieder venit, vidit, dixit 03.12.2013 00:37:
> When the built-in "git tar-tree" command (a thin wrapper around "git
> archive") was removed in 925ceccf (tar-tree: remove deprecated
> command, 2013-11-10), the build continued to install a non-functioning
> git-tar-tree command in gitexecdir by mistake:
>
> $ PATH=$(git --exec-path):$PATH
> $ git-tar-tree -h
> fatal: cannot handle tar-tree internally
>
> The list of links in gitexecdir is populated from BUILTIN_OBJS, which
> includes builtin/tar-tree.o to implement "git get-tar-commit-id".
... "which still resides in builtin/tar-tree.c"
Had me scratch my head quite a bit as is ;)
> Rename the get-tar-commit-id source file to builtin/get-tar-commit-id.c
> to reflect its purpose and fix 'make install'.
>
> Signed-off-by: Jonathan Nieder <jrnieder@gmail•com>
> ---
> Hi,
>
> John Keeping wrote:
>
>> builtin/tar-tree.c | 62 -------------------------
>
> Here's a quick fixup on top. Thoughts?
>
> Thanks,
> Jonathan
>
> Makefile | 3 +--
> builtin/{tar-tree.c => get-tar-commit-id.c} | 0
> 2 files changed, 1 insertion(+), 2 deletions(-)
> rename builtin/{tar-tree.c => get-tar-commit-id.c} (100%)
>
> diff --git a/Makefile b/Makefile
> index 504931f..37beb73 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -586,7 +586,6 @@ BUILT_INS += git-cherry$X
> BUILT_INS += git-cherry-pick$X
> BUILT_INS += git-format-patch$X
> BUILT_INS += git-fsck-objects$X
> -BUILT_INS += git-get-tar-commit-id$X
> BUILT_INS += git-init$X
> BUILT_INS += git-merge-subtree$X
> BUILT_INS += git-show$X
> @@ -929,6 +928,7 @@ BUILTIN_OBJS += builtin/fmt-merge-msg.o
> BUILTIN_OBJS += builtin/for-each-ref.o
> BUILTIN_OBJS += builtin/fsck.o
> BUILTIN_OBJS += builtin/gc.o
> +BUILTIN_OBJS += builtin/get-tar-commit-id.o
> BUILTIN_OBJS += builtin/grep.o
> BUILTIN_OBJS += builtin/hash-object.o
> BUILTIN_OBJS += builtin/help.o
> @@ -980,7 +980,6 @@ BUILTIN_OBJS += builtin/show-ref.o
> BUILTIN_OBJS += builtin/stripspace.o
> BUILTIN_OBJS += builtin/symbolic-ref.o
> BUILTIN_OBJS += builtin/tag.o
> -BUILTIN_OBJS += builtin/tar-tree.o
> BUILTIN_OBJS += builtin/unpack-file.o
> BUILTIN_OBJS += builtin/unpack-objects.o
> BUILTIN_OBJS += builtin/update-index.o
> diff --git a/builtin/tar-tree.c b/builtin/get-tar-commit-id.c
> similarity index 100%
> rename from builtin/tar-tree.c
> rename to builtin/get-tar-commit-id.c
>
next prev parent reply other threads:[~2013-12-04 10:23 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-10 15:47 [RFC/PATCH 0/4] Remove deprecated commands John Keeping
2013-11-10 15:47 ` [RFC/PATCH 1/4] repo-config: remove deprecated alias for "git config" John Keeping
2013-11-10 15:47 ` [RFC/PATCH 2/4] tar-tree: remove deprecated command John Keeping
2013-12-02 23:37 ` [PATCH jk/remove-deprecated] stop installing git-tar-tree link Jonathan Nieder
2013-12-03 20:19 ` John Keeping
2013-12-04 10:23 ` Michael J Gruber [this message]
2013-11-10 15:47 ` [RFC/PATCH 3/4] lost-found: remove deprecated command John Keeping
2013-11-10 15:47 ` [RFC/PATCH 4/4] peek-remote: remove deprecated alias of ls-remote John Keeping
2013-11-11 18:25 ` [RFC/PATCH 0/4] Remove deprecated commands Junio C Hamano
2013-11-11 18:38 ` John Keeping
2013-11-11 19:13 ` Jonathan Nieder
2013-11-11 21:10 ` John Keeping
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=529F02A3.2030704@drmicha.warpmail.net \
--to=git@drmicha$(echo .)warpmail.net \
--cc=git@vger$(echo .)kernel.org \
--cc=gitster@pobox$(echo .)com \
--cc=john@keeping$(echo .)me.uk \
--cc=jrnieder@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox