From: Marc Branchaud <marcnarc@xiplink•com>
To: Jonathan Nieder <jrnieder@gmail•com>
Cc: git@vger•kernel.org,
"Lucas Sandery [three am design]" <lucas@threeamdesign•com.au>,
Paul Mackerras <paulus@samba•org>
Subject: Re: [PATCHv2] gitk: Replace "next" and "prev" buttons with down and up arrows.
Date: Tue, 21 Jan 2014 10:33:02 -0500 [thread overview]
Message-ID: <52DE932E.7090008@xiplink.com> (raw)
In-Reply-To: <1387382653-8385-1-git-send-email-marcnarc@xiplink.com>
On 13-12-18 11:04 AM, Marc Branchaud wrote:
> Users often find that "next" and "prev" do the opposite of what they
> expect. For example, "next" moves to the next match down the list, but
> that is almost always backwards in time. Replacing the text with arrows
> makes it clear where the buttons will take the user.
Any opinions on this, either way?
I've grown fond of the down/up arrows. I find them much clearer than the
current next/prev buttons.
My only niggle about this patch is that the buttons are much smaller,
requiring a bit more precision clicking. But the smaller buttons allow more
room for other widgets.
M.
> Signed-off-by: Marc Branchaud <marcnarc@xiplink•com>
> ---
>
> Finally got around to drawing some up and down arrows.
>
> M.
>
> gitk | 30 ++++++++++++++++++++++++++++--
> 1 file changed, 28 insertions(+), 2 deletions(-)
>
> diff --git a/gitk b/gitk
> index 33c3a6c..abd2ef3 100755
> --- a/gitk
> +++ b/gitk
> @@ -2263,9 +2263,35 @@ proc makewindow {} {
>
> # build up the bottom bar of upper window
> ${NS}::label .tf.lbar.flabel -text "[mc "Find"] "
> - ${NS}::button .tf.lbar.fnext -text [mc "next"] -command {dofind 1 1}
> - ${NS}::button .tf.lbar.fprev -text [mc "prev"] -command {dofind -1 1}
> +
> + set bm_down_data {
> + #define down_width 16
> + #define down_height 16
> + static unsigned char down_bits[] = {
> + 0x80, 0x01, 0x80, 0x01, 0x80, 0x01, 0x80, 0x01,
> + 0x80, 0x01, 0x80, 0x01, 0x80, 0x01, 0x80, 0x01,
> + 0x87, 0xe1, 0x8e, 0x71, 0x9c, 0x39, 0xb8, 0x1d,
> + 0xf0, 0x0f, 0xe0, 0x07, 0xc0, 0x03, 0x80, 0x01};
> + }
> + image create bitmap bm-down -data $bm_down_data -foreground $uifgcolor
> + ${NS}::button .tf.lbar.fnext -width 26 -command {dofind 1 1}
> + .tf.lbar.fnext configure -image bm-down
> +
> + set bm_up_data {
> + #define up_width 16
> + #define up_height 16
> + static unsigned char up_bits[] = {
> + 0x80, 0x01, 0xc0, 0x03, 0xe0, 0x07, 0xf0, 0x0f,
> + 0xb8, 0x1d, 0x9c, 0x39, 0x8e, 0x71, 0x87, 0xe1,
> + 0x80, 0x01, 0x80, 0x01, 0x80, 0x01, 0x80, 0x01,
> + 0x80, 0x01, 0x80, 0x01, 0x80, 0x01, 0x80, 0x01};
> + }
> + image create bitmap bm-up -data $bm_up_data -foreground $uifgcolor
> + ${NS}::button .tf.lbar.fprev -width 26 -command {dofind -1 1}
> + .tf.lbar.fprev configure -image bm-up
> +
> ${NS}::label .tf.lbar.flab2 -text " [mc "commit"] "
> +
> pack .tf.lbar.flabel .tf.lbar.fnext .tf.lbar.fprev .tf.lbar.flab2 \
> -side left -fill y
> set gdttype [mc "containing:"]
>
next prev parent reply other threads:[~2014-01-21 15:41 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-01 2:31 gitk next/prev buttons Lucas Sandery [three am design]
2013-10-02 1:08 ` Lucas Sandery
2013-10-08 17:50 ` Marc Branchaud
2013-10-08 19:36 ` Jonathan Nieder
2013-10-08 20:45 ` Marc Branchaud
2013-12-18 16:04 ` [PATCHv2] gitk: Replace "next" and "prev" buttons with down and up arrows Marc Branchaud
2014-01-21 15:33 ` Marc Branchaud [this message]
2014-01-22 11:04 ` Paul Mackerras
2014-01-22 20:18 ` Junio C Hamano
2014-01-23 11:08 ` Paul Mackerras
2014-01-23 16:51 ` Junio C Hamano
2013-10-08 20:49 ` [PATCH] gitk: Rename "next" and "prev" buttons to "older" and "newer" Marc Branchaud
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52DE932E.7090008@xiplink.com \
--to=marcnarc@xiplink$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=jrnieder@gmail$(echo .)com \
--cc=lucas@threeamdesign$(echo .)com.au \
--cc=paulus@samba$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox