From: Mark Struberg <struberg@yahoo•de>
To: Robin Rosenberg <robin.rosenberg.lists@dewire•com>,
"Shawn O. Pearce" <spearce@spearce•org>
Cc: git@vger•kernel.org
Subject: Re: [JGIT PATCH] Fix data corruption in DirCacheIterator when EmptyTreeIterator is used
Date: Tue, 12 May 2009 00:04:06 +0000 (GMT) [thread overview]
Message-ID: <5323.360.qm@web27801.mail.ukl.yahoo.com> (raw)
Patch tested, jgit status now works on a repo which previously caused the out of bounds exception.
txs and LieGrue,
strub
--- Shawn O. Pearce <spearce@spearce•org> schrieb am Mo, 11.5.2009:
> Von: Shawn O. Pearce <spearce@spearce•org>
> Betreff: Re: [JGIT PATCH] Fix data corruption in DirCacheIterator when EmptyTreeIterator is used
> An: "Robin Rosenberg" <robin.rosenberg.lists@dewire•com>
> CC: "Mark Struberg" <struberg@yahoo•de>, git@vger•kernel.org
> Datum: Montag, 11. Mai 2009, 21:44
> Robin Rosenberg <robin.rosenberg.lists@dewire•com>
> wrote:
> >
> > Shouldn't we update some unit tests too? The dircache
> must be reliable.
>
> I see you ignored the remark I put in the cover letter
> below the ---.
>
> I think we should have unit tests too. I just can't
> come up with
> a way test the fix to prevent regression. And I don't
> have any
> more time for it probably the rest of this week. I'd
> rather have
> the corruption fix in the tree with no test than continue
> to have
> surprising corruption under certain cases. But if you
> or Mark can
> offer a test, I'd love to have it.
>
> --
> Shawn.
> --
> To unsubscribe from this list: send the line "unsubscribe
> git" in
> the body of a message to majordomo@vger•kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
next reply other threads:[~2009-05-12 0:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-12 0:04 Mark Struberg [this message]
-- strict thread matches above, loose matches on Subject: below --
2009-05-11 17:52 [JGIT PATCH] Fix data corruption in DirCacheIterator when EmptyTreeIterator is used Shawn O. Pearce
2009-05-11 18:59 ` Robin Rosenberg
2009-05-11 19:44 ` Shawn O. Pearce
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5323.360.qm@web27801.mail.ukl.yahoo.com \
--to=struberg@yahoo$(echo .)de \
--cc=git@vger$(echo .)kernel.org \
--cc=robin.rosenberg.lists@dewire$(echo .)com \
--cc=spearce@spearce$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox