Subject: Re: [PATCH] update-ref: fail create operation over stdin if ref already exists

From: Brad King <[email-masked]>
Date: Wed, 02 Apr 2014 08:57:15 -0400

On 04/02/2014 04:09 AM, Michael Haggerty wrote:
> From: Aman Gupta <[email-masked]>
[snip]
> @@ -147,6 +147,7 @@ static void parse_cmd_create(const char *next)
>  	struct ref_update *update;
>  
>  	update = update_alloc();
> +	update->have_old = 1;

Looks good.

> +test_expect_success 'stdin -z create ref fails when ref exists' '

Strictly speaking we should have a non-z mode test too.

Thanks,
-Brad