Subject: Re: [PATCH 06/10] log: --function-name pickaxe

From: Jakub Narębski <[email-masked]>
Date: Fri, 04 Apr 2014 13:15:49 +0200

W dniu 2014-04-03 23:44, Junio C Hamano pisze:
> René Scharfe <[email-masked]> writes:
>
>> With that approach you depend on the hunk header and apparently need
>> to add XDL_EMIT_MOREFUNCNAMES and XDL_EMIT_MOREHUNKHEADS to improve
>> the results.  This approach feels fragile.
>>
>> Would it perhaps be more robust to not base the implementation on diff
>> and instead to scan the raw file contents?
>
> That is an interesting idea.
>
> Perhaps this can be implemented as a new stage in the transformation
> pipeline, I wonder?  There is currently no transformation that
> modifies the blob contents being compared, but I do not think there
> is anything fundamental that prevents one from being written.  The
> new "limit to this function body" transformation would perhaps sit
> before the diffcore-rename and would transform all the blobs to
> empty, except for the part that is the body of the function the user
> is interested in.

Well, there is 'texconv', e.g.

   .gitattributes
   *.jpg diff=jpg

   .git/config
   [diff "jpg"]
          textconv = exif

Doesn't it fit in said place in the transformation pipeline?

-- 
Jakub Narębski