Subject: Re: [PATCH 18/22] lockfile: also keep track of the filename of the file being locked

From: Michael Haggerty <[email-masked]>
Date: Mon, 07 Apr 2014 00:05:57 +0200

On 04/02/2014 07:19 PM, Junio C Hamano wrote:
> Michael Haggerty <[email-masked]> writes:
> 
>> This reduces the amount of string editing gyrations and makes it
>> unnecessary for callers to know how to derive the filename from the
>> lock_filename.
> 
> Hmph.
> 
> Is it worth duplicating the whole thing?  If you are planning to
> break the invariant lock_filename === filename + LOCK_SUFFIX in
> future changes in the series, it is understandable, though.

That is indeed the plan, but I'm splitting that change into a future
patch series because this one is getting big enough already dealing with
correctness issues.

Michael

-- 
Michael Haggerty
[email-masked]
http://softwareswirl.blogspot.com/