From: Ramsay Jones <ramsay@ramsay1•demon.co.uk>
To: Jonathan Nieder <jrnieder@gmail•com>
Cc: GIT Mailing-list <git@vger•kernel.org>,
Ilya Bobyr <ilya.bobyr@gmail•com>,
Junio C Hamano <gitster@pobox•com>
Subject: Re: [PATCH/RFC] t0000-*.sh: Fix the GIT_SKIP_TESTS sub-tests
Date: Tue, 20 May 2014 23:20:04 +0100 [thread overview]
Message-ID: <537BD514.4040708@ramsay1.demon.co.uk> (raw)
In-Reply-To: <20140520214006.GT12314@google.com>
On 20/05/14 22:40, Jonathan Nieder wrote:
> Ramsay Jones wrote:
>
>> --- a/t/t0000-basic.sh
>> +++ b/t/t0000-basic.sh
>> @@ -296,8 +296,9 @@ test_expect_success 'test --verbose-only' '
>> '
>>
>> test_expect_success 'GIT_SKIP_TESTS' "
>> - GIT_SKIP_TESTS='git.2' \
>> - run_sub_test_lib_test git-skip-tests-basic \
>> + GIT_SKIP_TESTS='git.2' && export GIT_SKIP_TESTS &&
>> + test_when_finished sane_unset GIT_SKIP_TESTS &&
>
> Oof. Good catch.
>
> What should happen if I have set GIT_SKIP_TESTS explicitly to run
> only some of the tests in t0000-basic?
A quick test (with the above patch applied) shows that
it works as I would expect:
$ GIT_SKIP_TESTS=t0000.1[2-6] ./t0000-basic.sh
...
ok 11 - test --verbose
ok 12 # skip test --verbose-only (GIT_SKIP_TESTS)
ok 13 # skip GIT_SKIP_TESTS (GIT_SKIP_TESTS)
ok 14 # skip GIT_SKIP_TESTS several tests (GIT_SKIP_TESTS)
ok 15 # skip GIT_SKIP_TESTS sh pattern (GIT_SKIP_TESTS)
ok 16 # skip --run basic (GIT_SKIP_TESTS)
ok 17 - --run with a range
...
ok 77 - very long name in the index handled sanely
# passed all 77 test(s)
1..77
$
ATB,
Ramsay Jones
next prev parent reply other threads:[~2014-05-20 22:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-20 21:26 [PATCH/RFC] t0000-*.sh: Fix the GIT_SKIP_TESTS sub-tests Ramsay Jones
2014-05-20 21:33 ` Junio C Hamano
2014-05-20 21:40 ` Jonathan Nieder
2014-05-20 22:20 ` Ramsay Jones [this message]
2014-05-20 22:44 ` Jonathan Nieder
2014-05-20 23:33 ` Ramsay Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=537BD514.4040708@ramsay1.demon.co.uk \
--to=ramsay@ramsay1$(echo .)demon.co.uk \
--cc=git@vger$(echo .)kernel.org \
--cc=gitster@pobox$(echo .)com \
--cc=ilya.bobyr@gmail$(echo .)com \
--cc=jrnieder@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox