From: Michael Haggerty <mhagger@alum•mit.edu>
To: Azat Khuzhin <a3at.mail@gmail•com>, git@vger•kernel.org
Cc: Elijah Newren <newren@gmail•com>, Junio C Hamano <gitster@pobox•com>
Subject: Re: git-multimail: migration: Config is not iterable
Date: Sat, 31 May 2014 16:59:45 +0200 [thread overview]
Message-ID: <5389EE61.9060108@alum.mit.edu> (raw)
In-Reply-To: <20140529142208.GB27005@azat>
On 05/29/2014 04:22 PM, Azat Khuzhin wrote:
> Using the latest version of git-multimail there is an issue with
> migration:
>
> $ ~azat/git-multimail/git-multimail/migrate-mailhook-config --overwrite
> Traceback (most recent call last):
> File "/home/azat/git-multimail/git-multimail/migrate-mailhook-config", line 271, in <module>
> main(sys.argv[1:])
> File "/home/azat/git-multimail/git-multimail/migrate-mailhook-config", line 268, in main
> migrate_config(strict=options.strict, retain=options.retain, overwrite=options.overwrite)
> File "/home/azat/git-multimail/git-multimail/migrate-mailhook-config", line 159, in migrate_config
> if not _check_old_config_exists(old):
> File "/home/azat/git-multimail/git-multimail/migrate-mailhook-config", line 66, in _check_old_config_exists
> if name in old:
> TypeError: argument of type 'Config' is not iterable
>
> Tested on 2.6 and 2.7 python versions.
>
> If you revert 09d0d5b92203f019763e43cef1e57f76f117d2b4 ("Get Python files to
> pass pep8's tests.") there issue goes away. I understand that this is not the
> right solution and I'm not the guru of python, so just let you know.
Thanks for the bug report and for narrowing it down to the broken
commit. I just pushed a fix to GitHub. Let me know if it works for you
now.
Elijah: your fix is also correct, but I didn't see it before I pushed my
own solution. Sorry about that.
Junio: you don't have to worry about any of this, because the commit
that caused the breakage is not in your tree yet.
Michael
--
Michael Haggerty
mhagger@alum•mit.edu
next prev parent reply other threads:[~2014-05-31 14:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-29 14:22 git-multimail: migration: Config is not iterable Azat Khuzhin
2014-05-29 16:06 ` Elijah Newren
2014-05-31 14:59 ` Michael Haggerty [this message]
2014-05-31 15:21 ` Azat Khuzhin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5389EE61.9060108@alum.mit.edu \
--to=mhagger@alum$(echo .)mit.edu \
--cc=a3at.mail@gmail$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=gitster@pobox$(echo .)com \
--cc=newren@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox