Subject: Re: [PATCH 0/5] First part of Unicode console support for msysgit

From: Karsten Blees <[email-masked]>
Date: Fri, 06 Jun 2014 19:44:33 +0200

Am 06.06.2014 15:42, schrieb Stepan Kasal:
> Hello,
> 
> this is first part of the unicode support pathes from msysgit.
> 

Nicely done, thanks!

I think its important to reiterate that these patches were written several years apart, so there are some inconsistencies and back-and-forth changes (e.g. [5/5] fixes line break errors introduced in [3/5]). I'm OK with merging this as is, if there are no objections from the list, simply because it represents the battle tested history we have in Git for Windows.

The only real complaint I have is that I'm missing [6/5] "Win32: fix broken pipe detection" [1], which leaves this series in a slightly broken state (terminating the pager will not terminate the calling git process).

Nitpicking follows...

> The first three patches originate in Jun 2010, though some fixups from 2012
> have been squashed in.
> The fourth one is just a trivial prerequisite for
> the last one, that was written in Jan 2012, with a fixup from Mar 2012.
> 

The dates are missing from the patches.
It would also have been nice to name (or link to) the patches you sqashed.

> Regards,
> 	Stepan
> 
> Karsten Blees (5):
>   Support Unicode console output on Windows

This introduces WriteConsoleW, so you could have squashed half of "Win32: fix segfault in WriteConsoleW when debugging in gdb" [2] (second  half in [5/5]).

>   Detect console streams more reliably on Windows
>   Warn if the Windows console font doesn't support Unicode

I think this one includes "MSVC: fix winansi.c compile errors " [3] and "Unicode console: fix font warning on Vista and Win7" [4] (which is partly reverted by [5/5], which also fixes the formatting).

>   Win32: move main macro to a function

Note: this one was submitted seperately on May 29 and May 1 (can't find it in the gmane archive, though).

>   Win32: Thread-safe windows console output
> 
>  compat/mingw.c   |  24 ++-
>  compat/mingw.h   |  24 +--
>  compat/winansi.c | 446 ++++++++++++++++++++++++++++++++++++++++---------------
>  3 files changed, 356 insertions(+), 138 deletions(-)
> 

[1] https://github.com/msysgit/git/commit/67934f93
[2] https://github.com/msysgit/git/commit/cd0792af
[3] https://github.com/msysgit/git/commit/3abcb04d
[4] https://github.com/msysgit/git/commit/981aa538

-- 
-- 
*** Please reply-to-all at all times ***
*** (do not pretend to know who is subscribed and who is not) ***
*** Please avoid top-posting. ***
The msysGit Wiki is here: https://github.com/msysgit/msysgit/wiki - Github accounts are free.

You received this message because you are subscribed to the Google
Groups "msysGit" group.
To post to this group, send email to [email-masked]
To unsubscribe from this group, send email to
[email-masked]
For more options, and view previous threads, visit this group at
http://groups.google.com/group/msysgit?hl=en_US?hl=en

--- 
You received this message because you are subscribed to the Google Groups "msysGit" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email-masked].
For more options, visit https://groups.google.com/d/optout.