From: Paul Eggert <eggert@cs•ucla.edu>
To: Jeff King <peff@peff•net>
Cc: git@vger•kernel.org
Subject: Re: git format-patch doesn't add Content-type for UTF-8 diffs
Date: Mon, 30 Jun 2014 11:54:03 -0700 [thread overview]
Message-ID: <53B1B24B.2040609@cs.ucla.edu> (raw)
In-Reply-To: <20140630173052.GB16747@sigill.intra.peff.net>
Jeff King wrote:
> How do you send the mails after they come out of format-patch?
I run a shell command like this (on Solaris 10):
/usr/lib/sendmail -ONoRecipientAction=add-to tz@iana•org <
0001-whatever.patch
(The "NoRecipientAction" option pacifies the IANA MTA.)
This is an old machine not under my control, with an old 'git' installed
that I don't use and don't particularly want to worry about porting to.
I generate the patch file on a different machine with git 1.9.3, and
scp it into the email-sending machine.
I suppose that I could work around the problem with this shell command:
(grep -q '^Mime-Version: ' 0001-whatever.patch ||
printf '%s\n' \
'MIME-Version: 1.0' \
'Content-Type: text/plain; charset=UTF-8' \
'Content-Transfer-Encoding: 8bit'
cat 0001-whatever.patch) |
/usr/lib/sendmail -ONoRecipientAction=add-to tz@iana•org
but that's less convenient.
> I wonder if it would be enough to do:
>
> 1. Always add a content-type header, even if the commit is utf-8 and
> contains only ascii characters.
That would help for my case, yes. We use only UTF-8, and to me it
feelds weird that patches are mailed properly if the commit log contains
non-ASCII characters, but don't work if the commit log is ASCII and the
diff contains non-ASCII.
next prev parent reply other threads:[~2014-06-30 18:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-30 9:03 git format-patch doesn't add Content-type for UTF-8 diffs Paul Eggert
2014-06-30 17:30 ` Jeff King
2014-06-30 18:54 ` Paul Eggert [this message]
2014-07-01 4:38 ` Torsten Bögershausen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53B1B24B.2040609@cs.ucla.edu \
--to=eggert@cs$(echo .)ucla.edu \
--cc=git@vger$(echo .)kernel.org \
--cc=peff@peff$(echo .)net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox