Subject: Re: [PATCH 1/6] MinGW: Skip test redirecting to fd 4

From: Karsten Blees <[email-masked]>
Date: Thu, 17 Jul 2014 22:18:00 +0200

Am 17.07.2014 20:41, schrieb Junio C Hamano:
> Stepan Kasal <[email-masked]> writes:
> 
>> From: Johannes Schindelin <[email-masked]>
>>
>> ... because that does not work in MinGW.
>>
>> Signed-off-by: Johannes Schindelin <[email-masked]>
>> Signed-off-by: Stepan Kasal <[email-masked]>
>> ---
>>  t/t0081-line-buffer.sh | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/t/t0081-line-buffer.sh b/t/t0081-line-buffer.sh
>> index bd83ed3..25dba00 100755
>> --- a/t/t0081-line-buffer.sh
>> +++ b/t/t0081-line-buffer.sh
>> @@ -29,7 +29,7 @@ test_expect_success '0-length read, send along greeting' '
>>  	test_cmp expect actual
>>  '
>>  
>> -test_expect_success 'read from file descriptor' '
>> +test_expect_success NOT_MINGW 'read from file descriptor' '
>>  	rm -f input &&
>>  	echo hello >expect &&
>>  	echo hello >input &&
> 
> Hmm, the point of this test seems to be to exercise buffer_fdinit(),
> instead of buffer_init(), and the file descriptor does not have to
> be "4" for the purpose of the test, no?
> 
> Is what is broken on MinGW redirecting arbitrary file descrptors?

Yes. 0, 1 and 2 work (vie GetStdHandle), but anything else is handled
by the C-runtime. And as MSYS.dll (bash) and MSVCRT.dll (git) do it in
different ways, it doesn't work.

> -	echo copy 6 |
> -	test-line-buffer "&4" 4<input >actual &&
> +	test-line-buffer "&0" <input >actual &&

test-line-buffer already reads commands ("copy 6") from stdin, so stdin cannot
be reused for the data stream, unfortunately.

-- 
-- 
*** Please reply-to-all at all times ***
*** (do not pretend to know who is subscribed and who is not) ***
*** Please avoid top-posting. ***
The msysGit Wiki is here: https://github.com/msysgit/msysgit/wiki - Github accounts are free.

You received this message because you are subscribed to the Google
Groups "msysGit" group.
To post to this group, send email to [email-masked]
To unsubscribe from this group, send email to
[email-masked]
For more options, and view previous threads, visit this group at
http://groups.google.com/group/msysgit?hl=en_US?hl=en

--- 
You received this message because you are subscribed to the Google Groups "msysGit" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email-masked].
For more options, visit https://groups.google.com/d/optout.