Subject: Re: [PATCH v9 5/8] config: add `git_die_config()` to the config-set API

From: Tanay Abhra <[email-masked]>
Date: Fri, 08 Aug 2014 17:44:57 +0530

On 8/8/2014 12:25 AM, Junio C Hamano wrote:
> Tanay Abhra <[email-masked]> writes:
> 
>> diff --git a/Documentation/technical/api-config.txt b/Documentation/technical/api-config.txt
>> index 21f280c..0d8b99b 100644
>> --- a/Documentation/technical/api-config.txt
>> +++ b/Documentation/technical/api-config.txt
>> @@ -155,6 +155,19 @@ as well as retrieval for the queried variable, including:
>>  	Similar to `git_config_get_string`, but expands `~` or `~user` into
>>  	the user's home directory when found at the beginning of the path.
>>  
>> +`git_die_config(const char *key, const char *err, ...)`::
>> +
>> +	First prints the error message specified by the caller in `err` and then
>> +	dies printing the line number and the file name of the highest priority
>> +	value for the configuration variable `key`.
> 
> Reviewed with a wider context, I notice that this entry alone lacks
> the return type.  I am assuming that this is just an oversight, and
> adding 'void ' in front of the filename to match the next entry is
> simple enough.
> 

Yikes, yes, you are right, it's just an oversight. I will send an amended patch.