From: Phillip Wood <phillip.wood123@gmail•com>
To: Johannes Schindelin <Johannes.Schindelin@gmx•de>,
Patrick Steinhardt <ps@pks•im>
Cc: git@vger•kernel.org, Junio C Hamano <gitster@pobox•com>
Subject: Re: [PATCH v2 3/4] cmake: use verbatim arguments when invoking clar commands
Date: Thu, 14 Nov 2024 10:28:34 +0000 [thread overview]
Message-ID: <53d40c4a-0f88-428a-8fae-cd8cecbe1768@gmail.com> (raw)
In-Reply-To: <82d3f3aa-b11c-318f-9d47-35e0ebf3ebce@gmx.de>
Hi Johannes
On 13/11/2024 15:41, Johannes Schindelin wrote:
>
> I would not be surprised if this `VERBATIM` was unaware of the quirky
> escaping that the MSYS2 runtime (and therefore the Bash) requires. See the
> commit message of ad1559252945 (tests: add a helper to stress test
> argument quoting, 2019-09-18) for details.
>
> Having said that, this patch certainly does not make things _worse_, even
> if it probably does not have the intended effect on Windows. But then, it
> does not matter because most git/git source checkouts live at absolute
> paths that do not need to be quoted.
It may not be perfect but it is an improvement on Windows. When I was
playing around with
COMMAND ${SH_EXE} -c [[awk -f "$1" "$2" >"$3"]] ...
to build clar.suite on Windows it failed to work without VERBATIM.
Best Wishes
Phillip
> Ciao,
> Johannes
>
>>
>> Signed-off-by: Patrick Steinhardt <ps@pks•im>
>> ---
>> contrib/buildsystems/CMakeLists.txt | 6 ++++--
>> 1 file changed, 4 insertions(+), 2 deletions(-)
>>
>> diff --git a/contrib/buildsystems/CMakeLists.txt b/contrib/buildsystems/CMakeLists.txt
>> index 2db80b7cc3c6aba840f18ffdc78d2cda1877d8cd..8c71f5a1d0290c9204e094fb266f10c7b70af9fb 100644
>> --- a/contrib/buildsystems/CMakeLists.txt
>> +++ b/contrib/buildsystems/CMakeLists.txt
>> @@ -1009,13 +1009,15 @@ add_custom_command(OUTPUT "${CMAKE_BINARY_DIR}/t/unit-tests/clar-decls.h"
>> "${CMAKE_BINARY_DIR}/t/unit-tests/clar-decls.h"
>> ${clar_test_SUITES}
>> DEPENDS ${CMAKE_SOURCE_DIR}/t/unit-tests/generate-clar-decls.sh
>> - ${clar_test_SUITES})
>> + ${clar_test_SUITES}
>> + VERBATIM)
>> add_custom_command(OUTPUT "${CMAKE_BINARY_DIR}/t/unit-tests/clar.suite"
>> COMMAND ${SH_EXE} "${CMAKE_SOURCE_DIR}/t/unit-tests/generate-clar-suites.sh"
>> "${CMAKE_BINARY_DIR}/t/unit-tests/clar-decls.h"
>> "${CMAKE_BINARY_DIR}/t/unit-tests/clar.suite"
>> DEPENDS "${CMAKE_SOURCE_DIR}/t/unit-tests/generate-clar-suites.sh"
>> - "${CMAKE_BINARY_DIR}/t/unit-tests/clar-decls.h")
>> + "${CMAKE_BINARY_DIR}/t/unit-tests/clar-decls.h"
>> + VERBATIM)
>>
>> add_library(unit-tests-lib ${clar_test_SUITES}
>> "${CMAKE_SOURCE_DIR}/t/unit-tests/clar/clar.c"
>>
>> --
>> 2.47.0.229.g8f8d6eee53.dirty
>>
>>
next prev parent reply other threads:[~2024-11-14 10:28 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-08 13:16 [PATCH 0/3] Build improvements for clar Patrick Steinhardt
2024-11-08 13:16 ` [PATCH 1/3] t/unit-tests: convert "clar-generate.awk" into a shell script Patrick Steinhardt
2024-11-08 13:16 ` [PATCH 2/3] cmake: use SH_EXE to execute clar scripts Patrick Steinhardt
2024-11-08 13:16 ` [PATCH 3/3] Makefile: let clar header targets depend on their scripts Patrick Steinhardt
2024-11-10 14:30 ` [PATCH 0/3] Build improvements for clar Phillip Wood
2024-11-11 1:34 ` Junio C Hamano
2024-11-11 8:29 ` Patrick Steinhardt
2024-11-11 22:52 ` Junio C Hamano
2024-11-11 8:24 ` [PATCH v2 0/4] " Patrick Steinhardt
2024-11-11 8:24 ` [PATCH v2 1/4] t/unit-tests: convert "clar-generate.awk" into a shell script Patrick Steinhardt
2024-11-11 22:58 ` Junio C Hamano
2024-11-12 5:56 ` Patrick Steinhardt
2024-11-11 8:24 ` [PATCH v2 2/4] cmake: use SH_EXE to execute clar scripts Patrick Steinhardt
2024-11-11 8:24 ` [PATCH v2 3/4] cmake: use verbatim arguments when invoking clar commands Patrick Steinhardt
2024-11-13 15:41 ` Johannes Schindelin
2024-11-14 10:28 ` Phillip Wood [this message]
2024-11-11 8:25 ` [PATCH v2 4/4] Makefile: let clar header targets depend on their scripts Patrick Steinhardt
2024-11-11 10:09 ` [PATCH v2 0/4] Build improvements for clar Phillip Wood
2024-11-15 7:32 ` [PATCH v3 " Patrick Steinhardt
2024-11-15 7:32 ` [PATCH v3 1/4] t/unit-tests: convert "clar-generate.awk" into a shell script Patrick Steinhardt
2024-11-15 7:32 ` [PATCH v3 2/4] cmake: use SH_EXE to execute clar scripts Patrick Steinhardt
2024-11-18 18:47 ` Justin Tobler
2024-11-19 6:13 ` Patrick Steinhardt
2024-11-15 7:32 ` [PATCH v3 3/4] cmake: use verbatim arguments when invoking clar commands Patrick Steinhardt
2024-11-15 7:32 ` [PATCH v3 4/4] Makefile: let clar header targets depend on their scripts Patrick Steinhardt
2024-11-19 16:51 ` [PATCH v3 0/4] Build improvements for clar Justin Tobler
2024-11-20 1:24 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53d40c4a-0f88-428a-8fae-cd8cecbe1768@gmail.com \
--to=phillip.wood123@gmail$(echo .)com \
--cc=Johannes.Schindelin@gmx$(echo .)de \
--cc=git@vger$(echo .)kernel.org \
--cc=gitster@pobox$(echo .)com \
--cc=phillip.wood@dunelm$(echo .)org.uk \
--cc=ps@pks$(echo .)im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox