public inbox for git@vger.kernel.org 
 help / color / mirror / Atom feed

From: Johannes Sixt <j6t@kdbg•org>
To: Ben Walton <bdwalton@gmail•com>
Cc: karsten.blees@gmail•com, Junio C Hamano <gitster@pobox•com>,
	git <git@vger•kernel.org>
Subject: Re: [PATCH] Do not make trace.c/getnanotime an inlined function
Date: Mon, 29 Sep 2014 22:40:21 +0200	[thread overview]
Message-ID: <5429C3B5.5020401@kdbg.org> (raw)
In-Reply-To: <CAP30j14QGtHC7huU=3t4sJT_dZ3t9V=CBWyGyJW7EjT9H5ZK9w@mail.gmail.com>

Am 28.09.2014 um 22:42 schrieb Ben Walton:
> On Sun, Sep 28, 2014 at 8:15 PM, Johannes Sixt <j6t@kdbg•org
> <mailto:j6t@kdbg•org>> wrote:
>     Am 28.09.2014 um 09:50 schrieb Ben Walton:
>     > -inline uint64_t getnanotime(void)
>     > +uint64_t getnanotime(void)
> 
>     But then the function could stay static, no?
> 
> 
> This function is used in several places outside of the translation unit
> so while it's possible, I think it's more work than it's worth...

I see. I didn't check myself, sorry. I assumed that due to the 'inline'
the function would not have been available outside. Now your patch looks
good.

Thanks,
-- Hannes

next prev parent reply	other threads:[~2014-09-29 20:40 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-28  7:50 [PATCH] Do not make trace.c/getnanotime an inlined function Ben Walton
2014-09-28 19:15 ` Johannes Sixt
     [not found]   ` <CAP30j14QGtHC7huU=3t4sJT_dZ3t9V=CBWyGyJW7EjT9H5ZK9w@mail.gmail.com>
2014-09-29 20:40     ` Johannes Sixt [this message]
2014-09-29 12:44 ` Duy Nguyen
2014-09-29 17:48   ` Junio C Hamano
2014-09-30  9:25     ` Duy Nguyen
2014-09-30 15:54       ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5429C3B5.5020401@kdbg.org \
    --to=j6t@kdbg$(echo .)org \
    --cc=bdwalton@gmail$(echo .)com \
    --cc=git@vger$(echo .)kernel.org \
    --cc=gitster@pobox$(echo .)com \
    --cc=karsten.blees@gmail$(echo .)com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox