From: Ramsay Jones <ramsay@ramsay1•demon.co.uk>
To: Stefan Beller <sbeller@google•com>
Cc: Jeff King <peff@peff•net>,
"git@vger•kernel.org" <git@vger•kernel.org>,
Junio C Hamano <gitster@pobox•com>,
Michael Haggerty <mhagger@alum•mit.edu>,
Loic Dachary <loic@dachary•org>
Subject: Re: [PATCHv2 5/5] refs.c: enable large transactions
Date: Thu, 22 Jan 2015 19:51:28 +0000 [thread overview]
Message-ID: <54C154C0.9020708@ramsay1.demon.co.uk> (raw)
In-Reply-To: <CAGZ79kZnECcGOWKr4JLpF5zh68+L8XX7yYntyZDJTbZ5cLD50w@mail.gmail.com>
On 22/01/15 19:16, Stefan Beller wrote:
> How do you run sparse on git?
$ make sparse >sp-out 2>&1
>
> I noticed there is 'make sparse' though I cannot get it working
> here in the corporate world as I have problems with openssl
> headers not being found.
If you can build git with gcc, you should be able to run 'make sparse'
(modulo bugs, of course!). Having said that, I build sparse from source
and (on Linux) I'm running:
$ sparse --version
v0.5.0-30-gca3309e
$
The most up-to-date (from git://git.kernel.org/pub/scm/devel/sparse/sparse.git)
is actually:
$ sparse --version
v0.5.0-41-g6c2d743
$
which should work just fine. (I also run sparse on cygwin and MinGW).
>
> Also the line numbers seem to bit off compared to what I have
> here, did you need to modify/preprocess files to get sparse running?
No, I am simply building the 'pu' branch (currently @ 028c360).
>
> As for the fix, would it be sufficient to check != NULL instead of < 0?
Hmm, I didn't give it any thought, but don't you want that to be '== NULL'?
(you don't want to use a NULL lock->lk->fp in the following fprintf()).
Or simply '!fdopen_lock_file(lock->lk, "w")' I suppose.
ATB,
Ramsay Jones
next prev parent reply other threads:[~2015-01-22 19:57 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-22 2:32 [PATCHv2 0/5] Fix bug in large transactions Stefan Beller
2015-01-22 2:32 ` [PATCHv2 1/5] update-ref: test handling large transactions properly Stefan Beller
2015-01-22 10:54 ` Michael Haggerty
2015-01-22 13:07 ` Jeff King
2015-01-22 2:32 ` [PATCHv2 2/5] t7004: rename ULIMIT test prerequisite to ULIMIT_STACK_SIZE Stefan Beller
2015-01-22 2:32 ` [PATCHv2 3/5] refs.c: remove lock_fd from struct ref_lock Stefan Beller
2015-01-22 2:32 ` [PATCHv2 4/5] refs.c: have a write_sha1_to_lock_file wrapper Stefan Beller
2015-01-22 2:32 ` [PATCHv2 5/5] refs.c: enable large transactions Stefan Beller
2015-01-22 11:24 ` Michael Haggerty
2015-01-22 13:10 ` Jeff King
2015-01-22 16:33 ` Michael Haggerty
2015-01-22 19:24 ` Stefan Beller
2015-01-22 23:11 ` [RFC PATCH 0/5] So you dislike the sequence of system calls? Stefan Beller
2015-01-22 23:11 ` [PATCH 1/5] fixup for "refs.c: enable large transactions" Stefan Beller
2015-01-22 23:11 ` [PATCH 2/5] refs.c: remove unlock_ref from write_ref_sha1 Stefan Beller
2015-01-22 23:11 ` [PATCH 3/5] refs.c: move static functions to close and commit refs Stefan Beller
2015-01-22 23:11 ` [PATCH 4/5] refs.c: remove committing the ref from write_ref_sha1 Stefan Beller
2015-01-22 23:11 ` [PATCH 5/5] refs.c: write values to lock files early for committing Stefan Beller
2015-01-22 12:59 ` [PATCHv2 5/5] refs.c: enable large transactions Ramsay Jones
2015-01-22 19:16 ` Stefan Beller
2015-01-22 19:51 ` Ramsay Jones [this message]
2015-01-22 20:13 ` Ramsay Jones
2015-01-22 20:20 ` Stefan Beller
2015-01-22 20:59 ` Ramsay Jones
2015-01-22 12:05 ` [PATCHv2 0/5] Fix bug in " Michael Haggerty
2015-01-23 20:03 ` [PATCHv3 0/6] " Stefan Beller
2015-01-23 20:03 ` [PATCHv3 1/6] update-ref: test handling large transactions properly Stefan Beller
2015-01-23 20:03 ` [PATCHv3 2/6] t7004: rename ULIMIT test prerequisite to ULIMIT_STACK_SIZE Stefan Beller
2015-01-23 20:03 ` [PATCHv3 3/6] refs.c: remove lock_fd from struct ref_lock Stefan Beller
2015-01-23 20:04 ` [PATCHv3 4/6] refs.c: move static functions to close and commit refs Stefan Beller
2015-01-23 20:04 ` [PATCHv3 5/6] refs.c: remove unlock_ref and commit_ref from write_ref_sha1 Stefan Beller
2015-01-23 23:57 ` Junio C Hamano
2015-01-24 0:22 ` Stefan Beller
2015-01-24 0:39 ` Junio C Hamano
2015-01-24 1:04 ` Stefan Beller
2015-01-24 1:29 ` Junio C Hamano
2015-01-23 20:04 ` [PATCHv3 6/6] refs.c: enable large transactions Stefan Beller
2015-01-24 0:14 ` Junio C Hamano
2015-01-24 0:24 ` Stefan Beller
2015-01-24 0:38 ` Junio C Hamano
2015-01-26 19:30 ` Stefan Beller
2015-01-26 21:10 ` [PATCH] refs.c: clean up write_ref_sha1 returns Stefan Beller
2015-01-27 3:22 ` Junio C Hamano
2015-01-28 21:35 ` Stefan Beller
2015-01-27 3:17 ` [PATCHv3 6/6] refs.c: enable large transactions Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54C154C0.9020708@ramsay1.demon.co.uk \
--to=ramsay@ramsay1$(echo .)demon.co.uk \
--cc=git@vger$(echo .)kernel.org \
--cc=gitster@pobox$(echo .)com \
--cc=loic@dachary$(echo .)org \
--cc=mhagger@alum$(echo .)mit.edu \
--cc=peff@peff$(echo .)net \
--cc=sbeller@google$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox