public inbox for git@vger.kernel.org 
 help / color / mirror / Atom feed

From: Ramsay Jones <ramsay@ramsay1•demon.co.uk>
To: sebastien.guimmara@gmail•com
Cc: Junio C Hamano <gitster@pobox•com>,
	GIT Mailing-list <git@vger•kernel.org>
Subject: [PATCH] help.c: mark a file-local function static
Date: Tue, 19 May 2015 20:15:55 +0100	[thread overview]
Message-ID: <555B8BEB.1050103@ramsay1.demon.co.uk> (raw)


Commit 4f671d74 ("help: respect new common command grouping",
18-05-2015) adds the 'cmd_group_cmp' funtion as an external
symbol.

Noticed by sparse. ("'cmd_group_cmp' was not declared. Should it
be static?")

Signed-off-by: Ramsay Jones <ramsay@ramsay1•demon.co.uk>
---

Hi Sebastien,

If you need to re-roll the patches in your 'sg/help-group' branch,
could you please squash this into the relevant patch (commit 4f671d74).

Thanks!

ATB,
Ramsay Jones

 help.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/help.c b/help.c
index 71027b7..7881ab7 100644
--- a/help.c
+++ b/help.c
@@ -218,7 +218,7 @@ void list_commands(unsigned int colopts,
 	}
 }
 
-int cmd_group_cmp(const void *elem1, const void *elem2)
+static int cmd_group_cmp(const void *elem1, const void *elem2)
 {
 	const struct cmdname_help *e1 = elem1;
 	const struct cmdname_help *e2 = elem2;
-- 
2.4.0

next             reply	other threads:[~2015-05-19 19:16 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-19 19:15 Ramsay Jones [this message]
2015-05-19 19:17 ` [PATCH] help.c: mark a file-local function static Sébastien Guimmara

find likely ancestor, descendant, or conflicting patches for this message:
( dfblob:71027b7 dfblob:7881ab7 )
 OR (
bs:"[PATCH] help.c: mark a file-local function static" )
	(help)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=555B8BEB.1050103@ramsay1.demon.co.uk \
    --to=ramsay@ramsay1$(echo .)demon.co.uk \
    --cc=git@vger$(echo .)kernel.org \
    --cc=gitster@pobox$(echo .)com \
    --cc=sebastien.guimmara@gmail$(echo .)com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox