From: Michael J Gruber <git@drmicha•warpmail.net>
To: "Johannes Löthberg" <johannes@kyriasis•com>, git@vger•kernel.org
Subject: Re: [PATCH] receive-pack: Create a HEAD ref for ref namespace
Date: Fri, 05 Jun 2015 14:55:35 +0200 [thread overview]
Message-ID: <55719C47.6030600@drmicha.warpmail.net> (raw)
In-Reply-To: <ef4dae3e-3ae8-4727-9448-80f801e1dbdf@email.android.com>
Johannes Löthberg venit, vidit, dixit 05.06.2015 13:53:
> Ping.
>
> --
> Sincerely,
> Johannes Löthberg
> (Sent from my phone.)
>
It appears your patch proposes to fix a problem. It's a good idea to
expose the problem by writing a test so that one can check that the fix
actually fixes the problem.
(Also, your patch duplicates the line "struct strbuf namespaced_head_buf
= STRBUF_INIT;")
Michael
next prev parent reply other threads:[~2015-06-05 12:55 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-01 21:24 [PATCH] receive-pack: Create a HEAD ref for ref namespace Johannes Löthberg
2015-06-05 11:53 ` Johannes Löthberg
2015-06-05 12:55 ` Michael J Gruber [this message]
2015-06-05 13:50 ` Johannes Löthberg
2015-06-05 14:10 ` Johannes Löthberg
2015-06-05 14:12 ` [PATCH v2] Fix cloning from " Johannes Löthberg
2015-06-05 14:12 ` [PATCH v2 1/2] receive-pack: Create a HEAD ref for " Johannes Löthberg
2015-06-05 14:12 ` [PATCH v2 2/2] t: Add test for cloning from " Johannes Löthberg
2015-06-05 15:33 ` Junio C Hamano
2015-06-05 16:12 ` Johannes Löthberg
2015-06-05 16:22 ` Junio C Hamano
2015-06-05 16:31 ` Johannes Löthberg
2015-06-05 16:25 ` Johannes Löthberg
2015-06-05 16:46 ` Junio C Hamano
2015-06-05 17:02 ` [PATCH v3] receive-pack: Create a HEAD ref for " Johannes Löthberg
2015-06-05 17:08 ` Johannes Löthberg
2015-06-05 17:19 ` Junio C Hamano
2015-06-05 17:27 ` Johannes Löthberg
2015-06-05 17:42 ` [PATCH v4] " Johannes Löthberg
2015-06-10 23:39 ` Johannes Löthberg
2015-06-15 20:48 ` Junio C Hamano
2015-06-15 20:59 ` Johannes Löthberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55719C47.6030600@drmicha.warpmail.net \
--to=git@drmicha$(echo .)warpmail.net \
--cc=git@vger$(echo .)kernel.org \
--cc=johannes@kyriasis$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox