public inbox for git@vger.kernel.org 
 help / color / mirror / Atom feed
From: KK <horizn@wp•pl>
To: git@vger•kernel.org
Subject: slash in branch name
Date: Wed, 17 Jun 2015 20:16:10 +0100	[thread overview]
Message-ID: <5581C77A.3040703@wp.pl> (raw)

Hi,

After upgrade GIT from 1.7.2.5-3.1 to 1.7.10.4-1+wheezy1 following error 
appear:

git push central versions/4.3.2
Counting objects: 45, done.
Delta compression using up to 8 threads.
Compressing objects: 100% (28/28), done.
Writing objects: 100% (28/28), 13.01 KiB, done.
Total 28 (delta 22), reused 0 (delta 0)
remote: Update script started: Tue Jun 9 13:25:34 BST 2015
remote: Arguments: refs/heads/versions/4.3.2
2e5233728aecc6ac337f4d3a9f32281e7c786e27
ae25cc33f6cf745cfa1061cbdfaf445344a60d13
remote: Warning: using temporary hooks
remote: error: invalid key: hooks.denypush.branch.versions/4.3.2
remote: error: invalid key: hooks.allowmerge.versions/4.3.2
remote: Packages changed by this update:
remote:   think_3
remote:   hls_plugin_1
remote:   hal_av_1
remote:   rtsp_plugin_1
remote: Notifying the following package owners of this update:

hooks were downloaded from:
git://git.et.redhat.com/ovirt-server.git

My colleague did some research about that and it seems that this commit 
has stopped update hook working:

commit b09c53a3e331211fc0154de8ebb271e48f8c7ee5
Author: Libor Pechacek <lpechacek@suse•cz>
Date:   Sun Jan 30 20:40:41 2011 +0100

     Sanity-check config variable names

     Sanity-check config variable names when adding and retrieving them. 
  As a side
     effect code duplication between git_config_set_multivar and 
get_value (in
     builtin/config.c) was removed and the common functionality was 
placed in
     git_config_parse_key.

     This breaks a test in t1300 which used invalid section-less keys in 
the tests
     for "git -c". However, allowing such names there was useless, since 
there was
     no way to set them via config file, and no part of git actually 
tried to use
     section-less keys. This patch updates the test to use more 
realistic examples
     as well as adding its own test.

     Signed-off-by: Libor Pechacek <lpechacek@suse•cz>
     Acked-by: Jeff King <peff@peff•net>
     Signed-off-by: Junio C Hamano <gitster@pobox•com>


Could you please advise how to fix/revert this?

brgds,

             reply	other threads:[~2015-06-17 19:16 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-17 19:16 KK [this message]
2015-06-17 19:24 ` slash in branch name Jeff King
2015-06-17 19:38   ` KK

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5581C77A.3040703@wp.pl \
    --to=horizn@wp$(echo .)pl \
    --cc=git@vger$(echo .)kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox