Subject: Re: [PATCH v2 08/12] initial_ref_transaction_commit(): function for initial ref creation

From: Michael Haggerty <[email-masked]>
Date: Sat, 20 Jun 2015 04:15:53 +0200

On 06/15/2015 08:53 PM, Junio C Hamano wrote:
> Michael Haggerty <[email-masked]> writes:
> 
>> +	struct ref_transaction *t;
>> +	struct strbuf err = STRBUF_INIT;
>> +
>> +	t = ref_transaction_begin(&err);
>> +	if (!t)
>> +		die(err.buf);
> 
> Yikes, and sorry for sending three messages without consolidating
> against the same patch, but
> 
> 	die("%s", err.buf);
> 
> because
> 
> extern NORETURN void die(const char *err, ...) __attribute__((format (printf, 1, 2)));
> 
> in its declaration causes -Werror=format-security to barf.
> 
> Likewise for a few other instances of the same construct all in 
> the same file.

Thanks for catching this. I'll fix it in the re-roll (and also add that
gcc option to my config.mak for the future).

Michael

-- 
Michael Haggerty
[email-masked]