Subject: Re: bug: git-archive does not use the zip64 extension for archives with more than 16k entries

From: René Scharfe <[email-masked]>
Date: Wed, 12 Aug 2015 21:40:48 +0200

Am 11.08.2015 um 12:40 schrieb Johannes Schauer:
> Hi,
>
> for repositories with more than 16k files and folders, git-archive will create
> zip files which store the wrong number of entries. That is, it stores the
> number of entries modulo 16k. This will break unpackers that do not include
> code to support this brokenness.

The limit is rather 65535 entries, isn't it?  The entries field has two 
bytes, and they are used fully.

Which programs are affected? InfoZIP Zip 3.0 and 7-Zip 9.20 seem to 
handle an archive with more entries just fine.  The built-in 
functionality of Windows 10 doesn't.

Besides, 64K entries should be enough for anybody. ;-)

Seriously, though: What kind of repository has that many files and uses 
the ZIP format to distribute snapshots?  Just curious.

> Instead, git-archive should use the zip64 extension to handle more than 16k
> files and folders correctly.

That seems to be what InfoZIP does and Windows 10 handles it just fine. 
  If lower Windows versions and other popular extractors can unzip such 
archives as well then this might indeed be the way to go.

Thanks,
René