Subject: Re: [PATCH v3 3/4] refs: make refs/worktree/* per-worktree

From: Michael Haggerty <[email-masked]>
Date: Thu, 13 Aug 2015 22:16:50 +0200

On 08/13/2015 07:41 PM, David Turner wrote:
> On Thu, 2015-08-13 at 13:15 -0400, Eric Sunshine wrote:
>> On Wed, Aug 12, 2015 at 5:57 PM, David Turner <[email-masked]> wrote:
>>> diff --git a/t/t0060-path-utils.sh b/t/t0060-path-utils.sh
>>> index 93605f4..28e6dff 100755
>>> --- a/t/t0060-path-utils.sh
>>> +++ b/t/t0060-path-utils.sh
>>> +test_expect_success 'handle per-worktree refs in refs/worktree' '
>>> +       git commit --allow-empty -m "initial commit" &&
>>> +       git worktree add -b branch worktree &&
>>> +       (
>>> +               cd worktree &&
>>> +               git commit --allow-empty -m "test commit"  &&
>>> +               git for-each-ref | test_must_fail grep refs/worktree &&
>>
>> s/test_must_fail/!/
>>
>> From t/README:
>>
>>    On the other hand, don't use test_must_fail for running regular
>>    platform commands; just use '! cmd'.  We are not in the business
>>    of verifying that the world given to us sanely works.
> 
> When I make that change, my test fails with:
> 
> FATAL: Unexpected exit with code 2
> 
> Apparently, you can't use ! in pipelines like that.  So that's why I
> used test_must_fail.

You would have to negate the whole pipeline, like

    ! git for-each-ref | grep refs/worktree

The result of a pipeline is taken from the last command.

Michael

-- 
Michael Haggerty
[email-masked]