Subject: Re: [PATCH v5] git-p4: Obey core.ignorecase when using P4 client specs.

From: Luke Diamand <[email-masked]>
Date: Tue, 25 Aug 2015 07:54:18 +0100

On 24/08/15 22:30, [email-masked] wrote:
> From: Lars Schneider <[email-masked]>
>
> Thanks to Luke Diamand I realized the core problem and propose here a
> substiantially simpler fix to my PATCH v4.
>
> The test cases remain and prove the problem. In particular
> "8 - Clone path (ignorecase)" and
> "Add a new file and clone path with new file (ignorecase)" fail with the
> current implementation on OS X and Linux.

That's a lot simpler, thanks!

Could we give this its own command line option and git config variable?

Core.ignorecase gets set if the client is on a filing system that 
ignores case. This is slightly different - it squashes case in depot 
files for people with depots that have incorrectly jumbled-up case.

Conflating the two seems like it would cause confusion at some point - 
for example, I have no idea how the rest of git behaves if 
core.ignorecase is set to True on a case-preserving file system.

It would probably be necessary to change p4PathStartsWith() to also 
check the same flag.

>
> Lars Schneider (1):
>    git-p4: Obey core.ignorecase when using P4 client specs.
>
>   git-p4.py                         |   7 ++
>   t/t9821-git-p4-path-variations.sh | 200 ++++++++++++++++++++++++++++++++++++++
>   2 files changed, 207 insertions(+)
>   create mode 100755 t/t9821-git-p4-path-variations.sh
>
> --
> 1.9.5 (Apple Git-50.3)
>