From: Johannes Sixt <j6t@kdbg•org>
To: Stefan Beller <sbeller@google•com>
Cc: "git@vger•kernel.org" <git@vger•kernel.org>,
"Jeff King" <peff@peff•net>, "Junio C Hamano" <gitster@pobox•com>,
"Johannes Schindelin" <johannes.schindelin@gmail•com>,
"Jens Lehmann" <Jens.Lehmann@web•de>,
"Eric Sunshine" <ericsunshine@gmail•com>,
"Torsten Bögershausen" <tboegi@web•de>
Subject: Re: [PATCH 1/2] run-command: Remove set_nonblocking
Date: Fri, 6 Nov 2015 22:41:07 +0100 [thread overview]
Message-ID: <563D1E73.8080805@kdbg.org> (raw)
In-Reply-To: <CAGZ79kbNpwhOF2eveux+yXibrYx+_S6KjvqLV7yEfAe5Sdg4uA@mail.gmail.com>
Am 06.11.2015 um 20:00 schrieb Stefan Beller:
> On Thu, Nov 5, 2015 at 12:27 PM, Johannes Sixt <j6t@kdbg•org> wrote:
>> Here is a prototype patch. Feel free to pick it up. It marks a process
>> whose EOF we have found by setting .err to -1. It's probably better to
>> extend the meaning of the in_use indicator for this purpose.
>
> Thanks for the proposal, I'll take that and make in_use a tristate for now
> (an enum consisting of FREE, WORKING, WAIT_CLEANUP)
I'd like to report that the prototype patch works on Windows. I tested
it lightly using test-run-command with commands producing output from
around 100 bytes to 10MB. So, I'm confident that this is the right approach.
Thank you for keeping the ball rolling!
-- Hannes
next prev parent reply other threads:[~2015-11-06 21:41 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-05 18:17 [PATCH 0/2] Remove non-blocking fds from run-command Stefan Beller
2015-11-05 18:17 ` [PATCH 1/2] run-command: Remove set_nonblocking Stefan Beller
2015-11-05 18:45 ` Junio C Hamano
2015-11-05 19:22 ` Stefan Beller
2015-11-05 19:37 ` Junio C Hamano
2015-11-05 20:27 ` Johannes Sixt
2015-11-05 20:50 ` Junio C Hamano
2015-11-05 22:20 ` Stefan Beller
2015-11-06 5:51 ` Johannes Sixt
2015-11-06 19:00 ` Stefan Beller
2015-11-06 21:41 ` Johannes Sixt [this message]
2015-11-05 18:17 ` [PATCH 2/2] strbuf: Correct documentation for strbuf_read_once Stefan Beller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=563D1E73.8080805@kdbg.org \
--to=j6t@kdbg$(echo .)org \
--cc=Jens.Lehmann@web$(echo .)de \
--cc=ericsunshine@gmail$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=gitster@pobox$(echo .)com \
--cc=johannes.schindelin@gmail$(echo .)com \
--cc=peff@peff$(echo .)net \
--cc=sbeller@google$(echo .)com \
--cc=tboegi@web$(echo .)de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox