From: Johannes Sixt <j6t@kdbg•org>
To: Stefan Beller <sbeller@google•com>
Cc: "git@vger•kernel.org" <git@vger•kernel.org>,
Ramsay Jones <ramsay@ramsayjones•plus.com>,
Jacob Keller <jacob.keller@gmail•com>, Jeff King <peff@peff•net>,
Junio C Hamano <gitster@pobox•com>,
Jonathan Nieder <jrnieder@gmail•com>,
Johannes Schindelin <johannes.schindelin@gmail•com>,
Jens Lehmann <Jens.Lehmann@web•de>,
Eric Sunshine <ericsunshine@gmail•com>
Subject: Re: [PATCH] run-command: detect finished children by closed pipe rather than waitpid
Date: Wed, 11 Nov 2015 23:18:39 +0100 [thread overview]
Message-ID: <5643BEBF.6000804@kdbg.org> (raw)
In-Reply-To: <CAGZ79kZTiGGL0t-CkeuWDfzX-pK_Lu8PZzE1sutq2jR_23B5xg@mail.gmail.com>
Am 11.11.2015 um 21:53 schrieb Stefan Beller:
> On Wed, Nov 11, 2015 at 12:48 PM, Johannes Sixt <j6t@kdbg•org> wrote:
>> I wonder why task_finish() callback gets to choose a signal. The point here
>> is, IIUC, when one child dies, the others must be halted, too. SIGTERM seems
>> to be the only sensible choice.
>
> SIGKILL would also do?
>
> In case you know your children, you can also send a SIGUSR1 or SIGUSR2.
>...
> So I am not convinced SIGTERM is the only true choice here. And because I
> have no idea which of the signals may be useful in the future, I decided to
> go with all of them.
Fair enough.
-- Hannes
prev parent reply other threads:[~2015-11-11 22:18 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-06 23:48 [PATCH] run-command: detect finished children by closed pipe rather than waitpid Stefan Beller
2015-11-07 6:28 ` Torsten Bögershausen
2015-11-07 9:01 ` Johannes Sixt
2015-11-11 20:37 ` Stefan Beller
2015-11-11 20:48 ` Johannes Sixt
2015-11-11 20:53 ` Stefan Beller
2015-11-11 22:18 ` Johannes Sixt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5643BEBF.6000804@kdbg.org \
--to=j6t@kdbg$(echo .)org \
--cc=Jens.Lehmann@web$(echo .)de \
--cc=ericsunshine@gmail$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=gitster@pobox$(echo .)com \
--cc=jacob.keller@gmail$(echo .)com \
--cc=johannes.schindelin@gmail$(echo .)com \
--cc=jrnieder@gmail$(echo .)com \
--cc=peff@peff$(echo .)net \
--cc=ramsay@ramsayjones$(echo .)plus.com \
--cc=sbeller@google$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox