public inbox for git@vger.kernel.org 
 help / color / mirror / Atom feed

From: Ramsay Jones <ramsay@ramsayjones•plus.com>
To: rappazzo@gmail•com
Cc: Jeff King <peff@peff•net>, GIT Mailing-list <git@vger•kernel.org>
Subject: [PATCH] builtin/ff-refs.c: mark some file-local variables static
Date: Wed, 25 Nov 2015 22:01:50 +0000	[thread overview]
Message-ID: <56562FCE.7090007@ramsayjones.plus.com> (raw)


Signed-off-by: Ramsay Jones <ramsay@ramsayjones•plus.com>
---

Hi Michael,

If you need to re-roll the patches in your 'mr/ff-refs' branch,
could you please squash parts of this patch into the relevant
patches from your branch.

Thanks.

Also, I note that gcc complains about the two calls to chdir().
(warning: ignoring return value of ‘chdir’, declared with
attribute warn_unused_result [-Wunused-result])

ATB,
Ramsay Jones

 builtin/ff-refs.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/builtin/ff-refs.c b/builtin/ff-refs.c
index ae68cfb..db8c378 100644
--- a/builtin/ff-refs.c
+++ b/builtin/ff-refs.c
@@ -5,10 +5,10 @@
 #include "run-command.h"
 #include "worktree.h"
 
-int dry_run = 0;
-int no_wt = 0;
-struct worktree **worktrees;
-const char *padding = ".....................................................";
+static int dry_run = 0;
+static int no_wt = 0;
+static struct worktree **worktrees;
+static const char *padding = ".....................................................";
 
 static const char * const builtin_ff_refs_usage[] = {
 	N_("git ff-refs [<options>]"),
-- 
2.6.0

                 reply	other threads:[~2015-11-25 22:02 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

find likely ancestor, descendant, or conflicting patches for this message:
( dfblob:ae68cfb dfblob:db8c378 )
 OR (
bs:"[PATCH] builtin/ff-refs.c: mark some file-local variables static" )
	(help)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56562FCE.7090007@ramsayjones.plus.com \
    --to=ramsay@ramsayjones$(echo .)plus.com \
    --cc=git@vger$(echo .)kernel.org \
    --cc=peff@peff$(echo .)net \
    --cc=rappazzo@gmail$(echo .)com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox