Subject: Re: [PATCH 07/10] t5100-mailinfo.sh: use the $( ... ) construct for command substitution

From: Johannes Sixt <[email-masked]>
Date: Mon, 28 Dec 2015 08:44:20 +0100

Am 28.12.2015 um 02:59 schrieb Junio C Hamano:
> Junio C Hamano <[email-masked]> writes:
>
>> Very true.  Let's leave that kind of things as separate clean-ups
>> after these patches settle, as mixing manual and mechanical changes
>> in a single patch makes it harder to review.
>>
>> Thanks.
>
> So that I won't forget (I'll need to amend with your sign-off even
> if this one is satisfactory to you).
>
> -- >8 --
> From: Johannes Sixt <[email-masked]>
> Date: Tue, 22 Dec 2015 19:35:16 +0100
> Subject: [PATCH] t5100: no need to use 'echo' command substitutions for globbing
>
> Instead of making the shell expand 00* and invoke 'echo' with it,
> and then capturing its output as command substitution, just use
> the result of expanding 00* directly.
>
> Signed-off-by: Junio C Hamano <[email-masked]>
> ---
>   t/t5100-mailinfo.sh | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/t/t5100-mailinfo.sh b/t/t5100-mailinfo.sh
> index 4e52b3b..85b3df5 100755
> --- a/t/t5100-mailinfo.sh
> +++ b/t/t5100-mailinfo.sh
> @@ -23,7 +23,7 @@ check_mailinfo () {
>   }
>
>
> -for mail in $(echo 00*)
> +for mail in 00*
>   do
>   	test_expect_success "mailinfo $mail" '
>   		check_mailinfo $mail "" &&
> @@ -51,7 +51,7 @@ test_expect_success 'split box with rfc2047 samples' \
>   	echo total is $last &&
>   	test $(cat rfc2047/last) = 11'
>
> -for mail in $(echo rfc2047/00*)
> +for mail in rfc2047/00*
>   do
>   	test_expect_success "mailinfo $mail" '
>   		git mailinfo -u $mail-msg $mail-patch <$mail >$mail-info &&
>

Signed-off-by: Johannes Sixt <[email-masked]>

Thank you for making a proper patch!

-- Hannes