From: Michael J Gruber <git@drmicha•warpmail.net>
To: Jeff King <peff@peff•net>
Cc: git@vger•kernel.org
Subject: Re: [PATCH 2/2] t5510: do not leave changed cwd
Date: Fri, 4 Mar 2016 14:04:16 +0100 [thread overview]
Message-ID: <56D987D0.5030208@drmicha.warpmail.net> (raw)
In-Reply-To: <20160304115255.GB8355@sigill.intra.peff.net>
Jeff King venit, vidit, dixit 04.03.2016 12:52:
> On Fri, Mar 04, 2016 at 11:53:50AM +0100, Michael J Gruber wrote:
>
>> t5510 carefully keeps the cwd at the test root by using either subshells
>> or explicit cd'ing back to the root. Use a subshell for the last
>> subtest, too.
>
> I doubt this caused the heisenbug you saw, as we should have an absolute
> path for the trash-dir, and we "cd" to its containing directory before
> deleting it. But this is definitely a good thing to be doing anyway, to
> prevent surprises for new tests added to t5510.
Absolutely ;)
Michael
next prev parent reply other threads:[~2016-03-04 13:04 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-04 10:53 [PATCH/RFC 0/2] Test trash dir sanitizing Michael J Gruber
2016-03-04 10:53 ` [PATCH 1/2] test-lib: quote TRASH_DIRECTORY Michael J Gruber
2016-03-04 11:51 ` Jeff King
2016-03-04 13:03 ` Michael J Gruber
2016-03-04 13:09 ` Jeff King
2016-03-04 10:53 ` [PATCH 2/2] t5510: do not leave changed cwd Michael J Gruber
2016-03-04 11:52 ` Jeff King
2016-03-04 13:04 ` Michael J Gruber [this message]
2016-03-04 18:38 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56D987D0.5030208@drmicha.warpmail.net \
--to=git@drmicha$(echo .)warpmail.net \
--cc=git@vger$(echo .)kernel.org \
--cc=peff@peff$(echo .)net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox