From: "Tom G. Christensen" <tgc@jupiterrise•com>
To: Junio C Hamano <gitster@pobox•com>
Cc: git@vger•kernel.org, Jeff King <peff@peff•net>
Subject: Re: git segfaults on older Solaris releases
Date: Sat, 9 Apr 2016 09:02:38 +0200 [thread overview]
Message-ID: <5708A90E.1050705@jupiterrise.com> (raw)
In-Reply-To: <5706C0D4.9030707@jupiterrise.com>
On 07/04/16 22:19, Tom G. Christensen wrote:
> On 07/04/16 20:50, Junio C Hamano wrote:
>> Junio C Hamano <gitster@pobox•com> writes:
>> So perhaps this is all we need to fix your box.
>>
>> setup.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>
> I applied this patch to 2.8.0 and have completed a testsuite run on
> Solaris 2.6/x86 with only a few unrelated problems.
> I will continue testing on the other Solaris < 10 releases but I do not
> expect any difference in the outcome.
>
I've finished testing 2.8.1 and I found one more case where a null is
being printed and causing a segfault. This happens even on Solaris 8 and 9.
The failling test is t3200.63.
Here is the backtrace from a Solaris 8/SPARC machine:
(gdb) core trash directory.t3200-branch/core
[New LWP 1]
[Thread debugging using libthread_db enabled]
[New Thread 1 (LWP 1)]
Core was generated by `/export/home/tgc/buildpkg/git/src/git-2.8.1/git
branch --unset-upstream'.
Program terminated with signal SIGSEGV, Segmentation fault.
#0 0xfecb32cc in strlen () from /usr/lib/libc.so.1
(gdb) bt
#0 0xfecb32cc in strlen () from /usr/lib/libc.so.1
#1 0xfed06508 in _doprnt () from /usr/lib/libc.so.1
#2 0xfed08690 in vfprintf () from /usr/lib/libc.so.1
#3 0x001487bc in vreportf (prefix=<optimized out>, err=<optimized out>,
params=0xffbfe408) at usage.c:23
#4 0x0014881c in die_builtin (err=0x198f90 "Could not set '%s' to
'%s'", params=0xffbfe408) at usage.c:35
#5 0x00148934 in die (err=0x198f90 "Could not set '%s' to '%s'") at
usage.c:108
#6 0x000af1b0 in git_config_set_multivar_in_file (value=0x0,
key=0x1ecca0 "branch.master.remote",
config_filename=<optimized out>, value_regex=<optimized out>,
multi_replace=<optimized out>) at config.c:2226
#7 git_config_set_multivar_in_file (config_filename=0x0, key=0x1ecca0
"branch.master.remote", value=0x0,
value_regex=0x0, multi_replace=1) at config.c:2220
#8 0x0003aa6c in cmd_branch (argc=0, argv=0xffbfec00, prefix=<optimized
out>) at builtin/branch.c:793
#9 0x000255e8 in run_builtin (argv=0xffbfec00, argc=2, p=0x1c365c
<commands+84>) at git.c:353
#10 handle_builtin (argc=2, argv=0xffbfec00) at git.c:540
#11 0x00168ecc in run_argv (argv=0xffbfeb30, argcp=0xffbfebdc) at git.c:594
#12 main (argc=2, av=<optimized out>) at git.c:701
(gdb)
-tgc
next prev parent reply other threads:[~2016-04-09 7:03 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-07 18:18 git segfaults on older Solaris releases Tom G. Christensen
2016-04-07 18:32 ` Junio C Hamano
2016-04-07 18:50 ` Junio C Hamano
2016-04-07 18:56 ` David Turner
2016-04-07 19:07 ` Jeff King
2016-04-07 19:37 ` Junio C Hamano
2016-04-07 20:24 ` Jeff King
2016-04-07 20:19 ` Tom G. Christensen
2016-04-09 7:02 ` Tom G. Christensen [this message]
2016-04-09 17:39 ` Jeff King
2016-04-09 17:42 ` [PATCH 1/3] config: lower-case first word of error strings Jeff King
2016-04-09 17:42 ` [PATCH 2/3] git_config_set_multivar_in_file: all non-zero returns are errors Jeff King
2016-04-09 17:43 ` [PATCH 3/3] git_config_set_multivar_in_file: handle "unset" errors Jeff King
2016-04-09 20:17 ` git segfaults on older Solaris releases Tom G. Christensen
2016-04-09 20:35 ` Jeff King
2016-04-12 10:21 ` Patrick Steinhardt
2016-04-07 18:58 ` Tom G. Christensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5708A90E.1050705@jupiterrise.com \
--to=tgc@jupiterrise$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=gitster@pobox$(echo .)com \
--cc=peff@peff$(echo .)net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox