From: Ramsay Jones <ramsay@ramsayjones•plus.com>
To: "David Turner" <dturner@twopensource•com>,
git@vger•kernel.org, pclouds@gmail•co,
"Ævar Arnfjörð Bjarmason" <avarab@gmail•com>
Cc: "Nguyễn Thái Ngọc Duy" <pclouds@gmail•com>
Subject: Re: [PATCH v4 03/16] index-helper: new daemon for caching index and related stuff
Date: Wed, 13 Apr 2016 18:00:11 +0100 [thread overview]
Message-ID: <570E7B1B.6040207@ramsayjones.plus.com> (raw)
In-Reply-To: <1460507589-25525-4-git-send-email-dturner@twopensource.com>
On 13/04/16 01:32, David Turner wrote:
[snip]
> diff --git a/git-compat-util.h b/git-compat-util.h
> index c07e0c1..8b878fe 100644
> --- a/git-compat-util.h
> +++ b/git-compat-util.h
> @@ -513,6 +513,7 @@ static inline int ends_with(const char *str, const char *suffix)
> #define PROT_READ 1
> #define PROT_WRITE 2
> #define MAP_PRIVATE 1
> +#define MAP_SHARED 2
> #endif
>
> #define mmap git_mmap
> @@ -1045,4 +1046,21 @@ struct tm *git_gmtime_r(const time_t *, struct tm *);
> #define getc_unlocked(fh) getc(fh)
> #endif
>
> +#ifdef __linux__
> +#define UNIX_PATH_MAX 108
> +#elif defined(__APPLE__) || defined(BSD)
> +#define UNIX_PATH_MAX 104
> +#else
> +/*
> + * Quoth POSIX: The size of sun_path has intentionally been left
> + * undefined. This is because different implementations use different
> + * sizes. For example, 4.3 BSD uses a size of 108, and 4.4 BSD uses a
> + * size of 104. Since most implementations originate from BSD
> + * versions, the size is typically in the range 92 to 108.
> + *
> + * Thanks, POSIX! Super-helpful! Hope we don't overflow any buffers!
> + */
> +#define UNIX_PATH_MAX 92
> +#endif
> +
It seems you forgot to delete this hunk. ;-)
> #endif
ATB,
Ramsay Jones
next prev parent reply other threads:[~2016-04-13 17:00 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-13 0:32 [PATCH v4 00/16] index-helper, watchman David Turner
2016-04-13 0:32 ` [PATCH v4 01/16] read-cache.c: fix constness of verify_hdr() David Turner
2016-04-13 0:32 ` [PATCH v4 02/16] read-cache: allow to keep mmap'd memory after reading David Turner
2016-04-13 0:32 ` [PATCH v4 03/16] index-helper: new daemon for caching index and related stuff David Turner
2016-04-13 13:43 ` Duy Nguyen
2016-04-13 18:47 ` David Turner
2016-04-14 10:04 ` Duy Nguyen
2016-04-15 20:19 ` David Turner
2016-04-15 11:25 ` Duy Nguyen
2016-04-15 20:21 ` David Turner
2016-04-16 0:22 ` Duy Nguyen
2016-04-13 17:00 ` Ramsay Jones [this message]
2016-04-13 17:10 ` David Turner
2016-04-14 16:56 ` Junio C Hamano
2016-04-14 17:02 ` David Turner
2016-04-15 0:07 ` Duy Nguyen
2016-04-16 0:04 ` Stefan Beller
2016-04-19 22:00 ` David Turner
2016-04-19 22:00 ` David Turner
2016-04-13 0:32 ` [PATCH v4 04/16] index-helper: add --strict David Turner
2016-04-13 0:32 ` [PATCH v4 05/16] daemonize(): set a flag before exiting the main process David Turner
2016-04-13 0:32 ` [PATCH v4 06/16] index-helper: add --detach David Turner
2016-04-13 0:33 ` [PATCH v4 07/16] read-cache: add watchman 'WAMA' extension David Turner
2016-04-13 0:33 ` [PATCH v4 08/16] Add watchman support to reduce index refresh cost David Turner
2016-04-17 5:36 ` Duy Nguyen
2016-04-13 0:33 ` [PATCH v4 09/16] index-helper: use watchman to avoid refreshing index with lstat() David Turner
2016-04-16 0:07 ` Stefan Beller
2016-04-19 18:54 ` David Turner
2016-04-13 0:33 ` [PATCH v4 10/16] update-index: enable/disable watchman support David Turner
2016-04-13 0:33 ` [PATCH v4 11/16] unpack-trees: preserve index extensions David Turner
2016-04-13 0:33 ` [PATCH v4 12/16] index-helper: kill mode David Turner
2016-04-16 16:08 ` Ævar Arnfjörð Bjarmason
2016-04-19 22:14 ` David Turner
2016-04-13 0:33 ` [PATCH v4 13/16] index-helper: don't run if already running David Turner
2016-04-13 0:33 ` [PATCH v4 14/16] index-helper: autorun mode David Turner
2016-04-13 0:33 ` [PATCH v4 15/16] index-helper: optionally automatically run David Turner
2016-04-17 5:19 ` Duy Nguyen
2016-04-19 22:31 ` David Turner
2016-04-13 0:33 ` [PATCH v4 16/16] read-cache: config for waiting for index-helper David Turner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=570E7B1B.6040207@ramsayjones.plus.com \
--to=ramsay@ramsayjones$(echo .)plus.com \
--cc=avarab@gmail$(echo .)com \
--cc=dturner@twopensource$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=pclouds@gmail$(echo .)co \
--cc=pclouds@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox