From: Ramsay Jones <ramsay@ramsayjones•plus.com>
To: Junio C Hamano <gitster@pobox•com>, Elia Pinto <gitter.spiros@gmail•com>
Cc: git@vger•kernel.org, tboegi@web•de, sunshine@sunshineco•com,
peff@peff•net
Subject: Re: [PATCHv3 3/3] http.c: implements the GIT_TRACE_CURL environment variable
Date: Wed, 20 Apr 2016 20:56:28 +0100 [thread overview]
Message-ID: <5717DEEC.4000903@ramsayjones.plus.com> (raw)
In-Reply-To: <xmqqzisoun5n.fsf@gitster.mtv.corp.google.com>
On 20/04/16 19:53, Junio C Hamano wrote:
> Elia Pinto <gitter.spiros@gmail•com> writes:
>
>> Implements the GIT_TRACE_CURL environment variable to allow a
>
> s/Implements/Implement/; speak as if you are giving an order to the
> codebase to "be like so".
>
>> greater degree of detail of GIT_CURL_VERBOSE, in particular
>> the complete transport header and all the data payload exchanged.
>> It might be useful if a particular situation could require a more
>> thorough debugging analysis.
>>
>> Helped-by: Torsten Bögershausen <tboegi@web•de>
>> Helped-by: Ramsay Jones <ramsay@ramsayjones•plus.com>
>> Helped-by: Junio C Hamano <gitster@pobox•com>
>> Helped-by: Eric Sunshine <sunshine@sunshineco•com>
>> Helped-by: Jeff King <peff@peff•net>
>> Signed-off-by: Elia Pinto <gitter.spiros@gmail•com>
>> ---
>> http.c | 101 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++-
>> http.h | 6 ++++
>> 2 files changed, 106 insertions(+), 1 deletion(-)
>>
>> diff --git a/http.c b/http.c
>> index 4304b80..507c386 100644
>> --- a/http.c
>> +++ b/http.c
>> @@ -11,6 +11,7 @@
>> #include "gettext.h"
>> #include "transport.h"
>>
>> +static struct trace_key trace_curl = TRACE_KEY_INIT(CURL);
>> #if LIBCURL_VERSION_NUM >= 0x070a08
>> long int git_curl_ipresolve = CURL_IPRESOLVE_WHATEVER;
>> #else
>> @@ -464,6 +465,100 @@ static void set_curl_keepalive(CURL *c)
>> }
>> #endif
>>
>> +
>
> No need for this extra blank line.
>
>> +void curl_dump(const char *text, unsigned char *ptr, size_t size, char nohex)
>> +{
>> + size_t i;
>> + size_t w;
As I said in a previous email, curl_dump() should be marked
static here (and remove the declaration from http.h). Unless,
of course, there are plans for future use/calls being added?
ATB,
Ramsay Jones
next prev parent reply other threads:[~2016-04-20 19:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-20 16:28 [PATCHv3 0/3] Implements the GIT_TRACE_CURL environment variable Elia Pinto
2016-04-20 16:28 ` [PATCHv3 1/3] git.txt: document the new " Elia Pinto
2016-04-20 16:28 ` [PATCHv3 2/3] imap-send.c: introduce the GIT_TRACE_CURL enviroment variable Elia Pinto
2016-04-20 16:28 ` [PATCHv3 3/3] http.c: implements the GIT_TRACE_CURL environment variable Elia Pinto
2016-04-20 18:53 ` Junio C Hamano
2016-04-20 19:56 ` Ramsay Jones [this message]
2016-04-20 20:07 ` Junio C Hamano
2016-04-20 18:41 ` [PATCHv3 0/3] Implements " Junio C Hamano
2016-04-20 19:49 ` Ramsay Jones
2016-04-20 20:45 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5717DEEC.4000903@ramsayjones.plus.com \
--to=ramsay@ramsayjones$(echo .)plus.com \
--cc=git@vger$(echo .)kernel.org \
--cc=gitster@pobox$(echo .)com \
--cc=gitter.spiros@gmail$(echo .)com \
--cc=peff@peff$(echo .)net \
--cc=sunshine@sunshineco$(echo .)com \
--cc=tboegi@web$(echo .)de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox